Update test_crop_risk_scorer.py

test_crop_risk_scorer.py

@@ -29,7 +29,6 @@ from zone_observation import (
 @pytest.fixture
 def base_inputs():
     obs = make_synthetic_zone_obs("z", seed=0)
-    # FIX: parameter is horizon_days, not horizon
     fc  = make_synthetic_forecast_result("z", horizon_days=14, valid_time=obs.valid_time)
     return obs, fc
 
@@ -120,7 +119,6 @@ class TestForecastInfluence:
     def test_heavy_rain_forecast_increases_flood_risk(self, base_inputs):
         obs, fc = base_inputs
 
-        # FIX: parameter is horizon_days, not horizon
         fc_heavy = make_synthetic_forecast_result(
             "z", horizon_days=14, valid_time=obs.valid_time, flood=True
         )
@@ -133,7 +131,6 @@ class TestForecastInfluence:
     def test_drought_forecast_increases_drought_risk(self, base_inputs):
         obs, fc = base_inputs
 
-        # FIX: parameter is horizon_days, not horizon
         fc_dry = make_synthetic_forecast_result(
             "z", horizon_days=14, valid_time=obs.valid_time, drought=True
         )
@@ -153,19 +150,6 @@ class TestAlertThresholds:
     def test_critical_threshold(self, base_inputs):
         obs, fc = base_inputs
 
-        # PRE-EXISTING TEST BUG (found running this suite against the current
-        # scorer, not caused by it): supply_drought_weight only affects the
-        # `supply` composite, not drought_risk/flood_risk themselves, and
-        # WARNING's 0.65 cutoff has never moved regardless of any ADVISORY/
-        # WATCH threshold fix -- this test could never have passed as
-        # written. Fixed by maxing the raw fields drought_signal()/
-        # flood_signal() actually read, on BOTH the obs and forecast sides
-        # (_drought_risk/_flood_risk are 60/40 and 55/45 obs/forecast
-        # blends -- maxing only the obs left forecast pulling the blend back
-        # down). precip_anomaly_idx is a single shared axis (negative =
-        # drought, positive = flood), so "drought AND flood" both at max is
-        # constructed via the independent flood_extent_pct/drainage_risk_idx
-        # terms rather than via precip_anomaly_idx's sign.
         from zone_observation import ForecastResult
 
         obs_extreme = make_synthetic_zone_obs("z", drought=True, flood=True, seed=10)
@@ -223,11 +207,10 @@ class TestConfidence:
 
     def test_observational_data_has_higher_confidence(self):
         obs_obs = make_synthetic_zone_obs("z", seed=0)
-        # FIX: parameter is horizon_days, not horizon
         fc_obs  = make_synthetic_forecast_result("z", horizon_days=14, valid_time=obs_obs.valid_time)
 
         obs_lowq = make_synthetic_zone_obs("z", seed=1)
-        obs_lowq.quality_flag = 3  # degrade — ZoneObs is not frozen, mutation is safe
+        obs_lowq.quality_flag = 3
 
         rs_high = compute_risk_score(obs_obs, fc_obs)
         rs_low  = compute_risk_score(obs_lowq, fc_obs)
@@ -251,8 +234,6 @@ class TestStability:
 
     def test_no_nan_under_extreme_inputs(self):
         obs = make_synthetic_zone_obs("z", seed=99)
-        # FIX: ForecastResult is a frozen dataclass — cannot assign to fc.precip_mm.
-        # Construct a fresh instance with extreme precipitation values instead.
         fc_base = make_synthetic_forecast_result("z", horizon_days=30, valid_time=obs.valid_time)
         from zone_observation import ForecastResult
         fc = ForecastResult(
@@ -274,4 +255,4 @@ class TestStability:
 
         rs = compute_risk_score(obs, fc)
 
-        assert np.isfinite(rs.supply_shortfall_prob)
+        assert np.isfinite(rs.supply_shortfall_prob)