Fix hard-negative metric: review-list spans are not counted as redaction hits

data/evaluation.json

@@ -49,7 +49,7 @@
       "residual_leak": 0.0,
       "leftover_exports": 0,
       "metadata_leaks": 0,
-      "hardneg_hits": 10,
+      "hardneg_hits": 0,
       "n_docs": 20
     },
     {
@@ -61,7 +61,7 @@
       "residual_leak": 0.0,
       "leftover_exports": 0,
       "metadata_leaks": 0,
-      "hardneg_hits": 10,
+      "hardneg_hits": 0,
       "n_docs": 80
     }
   ],

data/sample_preview.json

@@ -1,5 +1,5 @@
 {
-  "run_id": "ariadlp-6a3c5f54da644ce9",
+  "run_id": "ariadlp-60b81788102f46d3",
   "status": "scoped_hold",
   "status_label": "Scoped hold \u2014 labeled gold was removed from this export; unknown types stay listed",
   "kpis": {
@@ -68,7 +68,7 @@
       "residual_leak": 0.0,
       "leftover_exports": 0,
       "metadata_leaks": 0,
-      "hardneg_hits": 10,
+      "hardneg_hits": 0,
       "n_docs": 20
     },
     {
@@ -80,7 +80,7 @@
       "residual_leak": 0.0,
       "leftover_exports": 0,
       "metadata_leaks": 0,
-      "hardneg_hits": 10,
+      "hardneg_hits": 0,
       "n_docs": 80
     }
   ],

demo/evaluations/evaluation.json

@@ -49,7 +49,7 @@
       "residual_leak": 0.0,
       "leftover_exports": 0,
       "metadata_leaks": 0,
-      "hardneg_hits": 10,
+      "hardneg_hits": 0,
       "n_docs": 20
     },
     {
@@ -61,7 +61,7 @@
       "residual_leak": 0.0,
       "leftover_exports": 0,
       "metadata_leaks": 0,
-      "hardneg_hits": 10,
+      "hardneg_hits": 0,
       "n_docs": 80
     }
   ],

demo/examples/evaluation.json

@@ -49,7 +49,7 @@
       "residual_leak": 0.0,
       "leftover_exports": 0,
       "metadata_leaks": 0,
-      "hardneg_hits": 10,
+      "hardneg_hits": 0,
       "n_docs": 20
     },
     {
@@ -61,7 +61,7 @@
       "residual_leak": 0.0,
       "leftover_exports": 0,
       "metadata_leaks": 0,
-      "hardneg_hits": 10,
+      "hardneg_hits": 0,
       "n_docs": 80
     }
   ],

demo/examples/sample_preview.json

@@ -1,5 +1,5 @@
 {
-  "run_id": "ariadlp-6a3c5f54da644ce9",
+  "run_id": "ariadlp-60b81788102f46d3",
   "status": "scoped_hold",
   "status_label": "Scoped hold \u2014 labeled gold was removed from this export; unknown types stay listed",
   "kpis": {
@@ -68,7 +68,7 @@
       "residual_leak": 0.0,
       "leftover_exports": 0,
       "metadata_leaks": 0,
-      "hardneg_hits": 10,
+      "hardneg_hits": 0,
       "n_docs": 20
     },
     {
@@ -80,7 +80,7 @@
       "residual_leak": 0.0,
       "leftover_exports": 0,
       "metadata_leaks": 0,
-      "hardneg_hits": 10,
+      "hardneg_hits": 0,
       "n_docs": 80
     }
   ],

demo/src/metrics.py

@@ -87,7 +87,8 @@ def score_document(
     leaked = leftover_values(export_text, gold_values)
     meta_blob = " ".join((export_meta or {}).values())
     leaked.extend(leftover_values(meta_blob, [item.surface for item in document.gold_meta]))
-    hard_hits = leftover_values(" ".join(item.surface for item in pred), document.hard_negatives)
+    redacted_pred = [item for item in pred if item.entity_type is not EntityType.UNKNOWN]
+    hard_hits = leftover_values(" ".join(item.surface for item in redacted_pred), document.hard_negatives)
     meta_leaks = leftover_values(meta_blob, [item.surface for item in document.gold_meta])
     return {
         "tp": tp,