Merge main (#62) into govpl: keep both source_findings entries

artifacts/source_findings.md

@@ -1261,6 +1261,36 @@ References: `rights_audit_2026-10/reports/citations.md` L10;
 from the official dump with page ids and licence templates, so each page can be
 screened and labelled.
 
+## biblioteka_nauki — public-domain-label records dropped (2026-10-06)
+
+**Verdict** — `added`, kept for v0.2.6 minus 3 records (polish-dynaword-v2#52). 42,071 →
+42,068 documents, 673,488,831 → 673,112,676 tokens (−376,155), 1,748,333,935 →
+1,747,387,478 characters. `src/clean_biblioteka_nauki.py` filters the v0.2.5 Parquet
+(pinned by SHA-256): it keeps `cc-by`, `cc-by-sa` and `cc0`, drops `public-domain`, and
+fails on any other value. `recover_attribution.py` no longer counts `public-domain` as clean.
+
+**Reason** — the 3 rows (`books_2142716`, `books_2147851`, `articles_2097363`) carry the
+platform's "Domena publiczna" label. Verified 2026-10-06 against
+`bibliotekanauki.pl/api/{type}/{id}`: licence id 22, `creativeCommons: false`, URL
+`creativecommons.org/publicdomain/mark/1.0/`. Creative Commons describes the Mark as "a tag
+or a label" for works already free of copyright; it grants nothing. All three are original
+texts (`reprintPublication` and `translationPublication` false) first published 2019, 2021
+and 2022 by named authors (Jerzy Zając, Witold Rakowski, Beata Michalec), so life+70 has
+not run out. The 2019 book's own colophon reads "Copyright by Jerzy Zając 2019 / Copyright
+by Muzeum Niepodległości w Warszawie 2019". That the authors are alive is inferred.
+
+**Not done here** — the licence version is still collapsed: rows say `cc-by`/`cc-by-sa`,
+the card and `stats.json` say 4.0. A live re-check (seed 20261006, 24 rows) found 4 of 12
+`cc-by` rows under 3.0 PL or 3.0 Unported; all 12 `cc-by-sa` rows were 4.0. Fixing it needs
+a per-record API re-fetch of name and version (tracked under polish-dynaword-v2#57). The
+card still names SpeakLeash while `src/sources.py` says direct rebuild; `licenses.jsonl`,
+`index.jsonl` and `build_parquet.py` are not in the repo. 128 kept rows (88 `cc-by`, 40
+`cc-by-sa`; 1.56% of tokens) contain "Wszelkie prawa zastrzeżone" or "All rights
+reserved" in their text (publication years 2010-2021); regex count only, not reviewed.
+
+**Lesson** — a platform's "public domain" label can be the PD Mark. Check the URL behind
+the label, and check the date: a 2019 work cannot be public domain by term in Poland.
+
 ## govpl — PAP reprints dropped (2026-10-06)
 
 **Verdict** — `kept`, minus 188 PAP reprints (slayerlabs/polish-dynaword-v2#51).

data/biblioteka_nauki/biblioteka_nauki.md

@@ -6,7 +6,7 @@ Biblioteka Nauki — Polish open-access scholarly corpus (scientific articles, b
 - **Source (upstream):** https://bibliotekanauki.pl (operated by ICM, University of Warsaw — Centrum Otwartej Nauki)
 - **Domain:** academic (scientific articles, books, chapters)
 - **Language:** Polish (pl)
-- **License:** per-document — CC BY 4.0 28,335 · CC BY-SA 4.0 13,733 · Public Domain 3
+- **License:** per-document — CC BY 4.0 28,335 · CC BY-SA 4.0 13,733
 - **Created (range):** per-document publication year, from each item's bibliotekanauki.pl metadata
 - **Added:** 2026-06-27
 
@@ -20,10 +20,16 @@ items are kept; all-rights-reserved and unknown items are gated out. Recovery yi
 |---|---:|
 | CC BY 4.0 | 28,335 |
 | CC BY-SA 4.0 | 13,733 |
-| Public Domain | 3 |
 
 The per-document license is carried in the parquet `license` column.
 
+Three items labelled "Domena publiczna" were dropped for v0.2.6 (`src/clean_biblioteka_nauki.py`,
+polish-dynaword-v2#52): `books_2142716`, `books_2147851`, `articles_2097363` (376,155 tokens).
+Biblioteka Nauki gives them API licence id 22, the CC Public Domain Mark 1.0, which is a label, not a
+waiver or a licence. They are original works first published 2019-2022, so the Polish life+70 term has
+not run out, and `books_2147851` itself prints "Copyright by Jerzy Zając 2019". Only CC BY, CC BY-SA
+and CC0 values are kept; any other value fails the script.
+
 ## Attribution
 Per-document attribution (author · year · title · publisher) was re-fetched 1:1 from
 bibliotekanauki.pl (43,576 / 43,576 ok) and is carried in the parquet `attribution` column,
@@ -37,7 +43,7 @@ attribution recovered per document and preserved.
 ## Statistics
 | documents | characters | tokens (tiktoken proxy) |
 |---:|---:|---:|
-| 42,071 | 1,748,333,935 | 673,488,831 |
+| 42,068 | 1,747,387,478 | 673,112,676 |
 
 ## Filters applied (build_dynaword.py)
 Minimal, per Dynaword guidelines (heavy filtering left to downstream use):
@@ -45,7 +51,8 @@ Minimal, per Dynaword guidelines (heavy filtering left to downstream use):
 - drop non-Polish (diacritic ratio): **925**
 - exact cross-source dedup (sha1): **180**
 - OCR alpha-ratio < 0.70 (OCR source): **400**
-- read 43,576 → kept 42,071
+- licence not an established grant, CC Public Domain Mark (`src/clean_biblioteka_nauki.py`): **3**
+- read 43,576 → kept 42,068
 
 Token counts are a fast tiktoken (cl100k) proxy (~1% off Llama-3); the canonical
 Llama-3 count is computed at release.

data/biblioteka_nauki/biblioteka_nauki.parquet

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:cc93cdd5ca3e6576a1da0aa294df1308e879b8516ac30911289e430c69a07b26
-size 1076638904
+oid sha256:6b57b8eec198c9899198a73cea1af372df09b43783a49474a856ccbf83c97da4
+size 1075953966

data/biblioteka_nauki/biblioteka_nauki.stats.json

@@ -1,12 +1,18 @@
 {
   "read": 43576,
-  "kept": 42071,
+  "kept": 42068,
   "drop_short": 0,
   "drop_lang": 925,
   "drop_dup": 180,
   "drop_ocr": 400,
-  "chars": 1748333935,
-  "tokens": 673488831,
+  "chars": 1747387478,
+  "tokens": 673112676,
   "secs": 484.1,
-  "license": "CC-BY-4.0 / CC-BY-SA-4.0"
+  "license": "CC-BY-4.0 / CC-BY-SA-4.0",
+  "drop_rights": 3,
+  "licenses": {
+    "cc-by": 28335,
+    "cc-by-sa": 13733
+  },
+  "input_sha256": "cc93cdd5ca3e6576a1da0aa294df1308e879b8516ac30911289e430c69a07b26"
 }

data/biblioteka_nauki/recover_attribution.py

@@ -1,5 +1,5 @@
 #!/usr/bin/env python3
-"""Targeted attribution pass for the CLEAN (CC-BY/CC-BY-SA/PD) Biblioteka Nauki ids ONLY.
+"""Targeted attribution pass for the CLEAN (CC-BY/CC-BY-SA/CC0) Biblioteka Nauki ids ONLY.
 The first recovery pass stored the license correctly but parsed the wrong attribution fields.
 CC-BY/CC-BY-SA legally REQUIRE attribution, so re-fetch just the ~43.6k clean ids and extract:
   authors = contributors[role=AUTHOR] firstName+lastName ; year = dates[PUBLISHED].date.year ;
@@ -16,7 +16,10 @@ HERE = os.path.dirname(os.path.abspath(__file__))
 LIC = os.path.join(HERE, "licenses.jsonl")
 OUT = os.path.join(HERE, "attribution.jsonl")
 PROG = os.path.join(HERE, "attribution_progress.txt")
-CLEAN = {"cc-by", "cc-by-sa", "cc0", "public-domain"}
+# The v0.2.4 run also kept "public-domain": the CC Public Domain Mark, a label rather than a grant
+# (polish-dynaword-v2#52). src/clean_biblioteka_nauki.py drops it from the shipped Parquet; its KEEP
+# set must equal this one.
+CLEAN = {"cc-by", "cc-by-sa", "cc0"}
 WORKERS = 8
 UA = ("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 "
       "(KHTML, like Gecko) Chrome/124 Safari/537.36")

src/clean_biblioteka_nauki.py

@@ -0,0 +1,81 @@
+#!/usr/bin/env python3
+"""Drop Biblioteka Nauki rows whose licence is not an established grant.
+
+Kept: `cc-by`, `cc-by-sa` and `cc0` (none in v0.2.5), the per-item Creative Commons licence read from
+bibliotekanauki.pl/api/{type}/{id} (`license.iconId`) by data/biblioteka_nauki/recover_licenses.py.
+Dropped: `public-domain`. The platform shows it for items tagged with the CC Public Domain Mark 1.0
+(API licence id 22, https://creativecommons.org/publicdomain/mark/1.0/). The Mark is a label, not
+a waiver or a licence, and the 3 tagged items are original works first published 2019-2022, so
+the Polish life+70 term cannot have run out (polish-dynaword-v2#52,
+artifacts/rights_audit_2026-10/reports/academic.md). Any other licence value fails the run.
+
+The v0.2.4 assembly script (build_parquet.py) was never committed, so this filters the shipped
+v0.2.5 Parquet, pinned by SHA-256, and updates the stats file in place. Rerun:
+  git checkout v0.2.5 -- data/biblioteka_nauki/biblioteka_nauki.parquet
+  python3 src/clean_biblioteka_nauki.py
+"""
+from __future__ import annotations
+
+import argparse
+import hashlib
+import json
+import os
+from collections import Counter
+from pathlib import Path
+
+import pyarrow as pa
+import pyarrow.compute as pc
+import pyarrow.parquet as pq
+
+SOURCE = "biblioteka_nauki"
+DATA = Path(__file__).resolve().parents[1] / "data" / SOURCE
+INPUT_SHA256 = "cc93cdd5ca3e6576a1da0aa294df1308e879b8516ac30911289e430c69a07b26"  # v0.2.5
+KEEP = {"cc-by", "cc-by-sa", "cc0"}  # = CLEAN in data/biblioteka_nauki/recover_attribution.py
+DROP = {"public-domain"}  # CC Public Domain Mark: a label, not a grant (see docstring)
+
+
+def filter_table(table: pa.Table) -> pa.Table:
+    """Rows whose `license` is in KEEP. Fails on any value in neither KEEP nor DROP."""
+    if unknown := set(table.column("license").unique().to_pylist()) - KEEP - DROP:
+        raise SystemExit(f"unexpected license values: {sorted(unknown, key=str)}")
+    return table.filter(pc.is_in(table.column("license"), pa.array(sorted(KEEP))))
+
+
+def build(input_path: Path, out_dir: Path) -> dict:
+    with input_path.open("rb") as stream:
+        if hashlib.file_digest(stream, "sha256").hexdigest() != INPUT_SHA256:
+            raise SystemExit(f"{input_path} is not the v0.2.5 Parquet; restore it with "
+                             f"`git checkout v0.2.5 -- data/{SOURCE}/{SOURCE}.parquet`")
+    table = pq.read_table(input_path)
+    kept = filter_table(table)
+    dropped = sorted(set(table.column("id").to_pylist()) - set(kept.column("id").to_pylist()))
+
+    stats_path = out_dir / f"{SOURCE}.stats.json"
+    stats = json.loads(stats_path.read_text(encoding="utf-8"))  # keeps build_dynaword's read/drop_* counts
+    stats.update(
+        kept=kept.num_rows,
+        drop_rights=table.num_rows - kept.num_rows,
+        chars=pc.sum(pc.utf8_length(kept.column("text"))).as_py(),
+        tokens=pc.sum(kept.column("token_count")).as_py(),
+        licenses=dict(sorted(Counter(kept.column("license").to_pylist()).items())),
+        input_sha256=INPUT_SHA256,
+    )
+    parquet_tmp = out_dir / f"{SOURCE}.parquet.tmp"
+    stats_tmp = out_dir / f"{SOURCE}.stats.json.tmp"
+    pq.write_table(kept, parquet_tmp)
+    stats_tmp.write_text(json.dumps(stats, indent=2, ensure_ascii=False) + "\n", encoding="utf-8")
+    os.replace(parquet_tmp, out_dir / f"{SOURCE}.parquet")
+    os.replace(stats_tmp, stats_path)
+    return {**stats, "dropped_ids": dropped}
+
+
+def main() -> None:
+    parser = argparse.ArgumentParser(description=__doc__.split("\n")[0])
+    parser.add_argument("--input", type=Path, default=DATA / f"{SOURCE}.parquet")
+    parser.add_argument("--out", type=Path, default=DATA)
+    args = parser.parse_args()
+    print(json.dumps(build(args.input, args.out), indent=2, ensure_ascii=False))
+
+
+if __name__ == "__main__":
+    main()

src/test_biblioteka_nauki_contract.py

@@ -0,0 +1,69 @@
+"""Contract checks for biblioteka_nauki after the public-domain drop (src/clean_biblioteka_nauki.py)."""
+
+import importlib.util
+import json
+import sys
+from collections import Counter
+from pathlib import Path
+
+import pyarrow as pa
+import pyarrow.compute as pc
+import pyarrow.parquet as pq
+import pytest
+
+sys.path.insert(0, str(Path(__file__).resolve().parent))
+
+from clean_biblioteka_nauki import DATA, KEEP, filter_table
+
+PUBLIC_DOMAIN_MARK_IDS = {
+    "biblioteka_nauki_books_2142716",
+    "biblioteka_nauki_books_2147851",
+    "biblioteka_nauki_articles_2097363",
+}
+
+
+def test_shard_has_no_public_domain_rows_and_matches_stats():
+    stats = json.loads((DATA / "biblioteka_nauki.stats.json").read_text(encoding="utf-8"))
+    path = DATA / "biblioteka_nauki.parquet"
+    assert pq.read_schema(path).names == [
+        "id", "text", "source", "added", "created", "token_count", "license", "attribution"]
+    table = pq.read_table(path, columns=["id", "source", "token_count", "license", "attribution"])
+    ids = table.column("id").to_pylist()
+    licenses = Counter(table.column("license").to_pylist())
+
+    assert table.num_rows == stats["kept"] == 42_068
+    assert len(set(ids)) == len(ids)
+    assert not PUBLIC_DOMAIN_MARK_IDS & set(ids)
+    assert "public-domain" not in licenses
+    assert licenses == stats["licenses"] == {"cc-by": 28_335, "cc-by-sa": 13_733}
+    assert set(table.column("source").to_pylist()) == {"biblioteka_nauki"}
+    assert pc.sum(table.column("token_count")).as_py() == stats["tokens"]
+    assert pc.min(table.column("token_count")).as_py() > 0
+    assert all(a and a.strip() for a in table.column("attribution").to_pylist())
+    drops = ("drop_short", "drop_lang", "drop_dup", "drop_ocr", "drop_rights")
+    assert stats["read"] - sum(stats[k] for k in drops) == stats["kept"]
+    assert stats["drop_rights"] == 3
+
+
+def test_datasheet_counts_match_stats():
+    stats = json.loads((DATA / "biblioteka_nauki.stats.json").read_text(encoding="utf-8"))
+    card = (DATA / "biblioteka_nauki.md").read_text(encoding="utf-8")
+    assert f"| {stats['kept']:,} | {stats['chars']:,} | {stats['tokens']:,} |" in card
+    for license, docs in stats["licenses"].items():
+        assert f"{docs:,}" in card, license
+    assert "| Public Domain |" not in card
+
+
+def test_filter_drops_public_domain_and_fails_closed():
+    table = pa.table({"id": ["a", "b", "c", "d"], "license": ["cc-by", "public-domain", "cc-by-sa", "cc0"]})
+    assert filter_table(table).column("id").to_pylist() == ["a", "c", "d"]
+    for bad in ("cc-by-nc", "cc-by-nd", "all-rights-reserved", None):
+        with pytest.raises(SystemExit):
+            filter_table(pa.table({"license": ["cc-by", bad]}))
+
+
+def test_upstream_gate_matches_filter():
+    spec = importlib.util.spec_from_file_location("recover_attribution", DATA / "recover_attribution.py")
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    assert module.CLEAN == KEEP