Update the security master

recipe/hf_jobs.py

@@ -14,7 +14,7 @@ from __future__ import annotations
 from dataclasses import dataclass
 from typing import Any
 
-from .config import DEFAULT_HF_REPO, validate_sec_user_agent
+from .config import DEFAULT_HF_REPO
 
 # The work is downloading the sibling datasets and four hundred settlement
 # archives, then a few minutes of grouping. Memory is modest; bandwidth is not.
@@ -109,16 +109,16 @@ def backfill_spec(
     )
 
 
-def job_secrets(*, hf_token: str, sec_user_agent: str) -> dict[str, str]:
-    """Validate credentials locally so a misconfigured job fails before it costs money."""
-
-    if not hf_token.strip():
-        raise ValueError("HF_TOKEN is required to create or run a Hugging Face Job")
-    return {
-        "HF_TOKEN": hf_token.strip(),
-        "SEC_USER_AGENT": validate_sec_user_agent(sec_user_agent),
-    }
+def job_secrets(*, hf_token: str) -> dict[str, str]:
+    """Credentials the Job needs, and only those.
 
+    No SEC User-Agent here: this dataset fetches nothing from SEC. It is
+    derived entirely from a sibling dataset on the Hub, so the only secret it
+    can use is the token that reads and writes it.
+    """
+    if not hf_token:
+        raise ValueError("an HF token is required to run or schedule a Job")
+    return {"HF_TOKEN": hf_token}
 
 def _api(token: str | None) -> Any:
     try:

tests/test_docs_and_jobs.py

@@ -0,0 +1,68 @@
+"""The published documents and the job must describe what is actually built."""
+
+from __future__ import annotations
+
+import json
+import re
+import tomllib
+from pathlib import Path
+
+import yaml
+
+from recipe.hf_jobs import DEFAULT_SCHEDULE, JOB_SCRIPT
+from recipe.schema import CONFIG_SCHEMAS
+
+ROOT = Path(__file__).resolve().parents[1]
+
+
+def _frontmatter() -> dict:
+    text = (ROOT / "README.md").read_text(encoding="utf-8")
+    assert text.startswith("---\n")
+    return yaml.safe_load(text.split("---\n", 2)[1])
+
+
+def test_readme_declares_every_config():
+    assert {entry["config_name"] for entry in _frontmatter()["configs"]} == set(CONFIG_SCHEMAS)
+
+
+def test_readme_has_no_unfilled_placeholders():
+    assert not re.findall(r"\{\{[A-Z_]+\}\}", (ROOT / "README.md").read_text(encoding="utf-8"))
+
+
+def test_job_script_declares_every_runtime_dependency():
+    """A Job installs from the script header alone; a gap fails only in the cloud."""
+    project = tomllib.loads((ROOT / "pyproject.toml").read_text(encoding="utf-8"))["project"]
+    required = {re.split(r"[<>=]", n, maxsplit=1)[0].strip().lower() for n in project["dependencies"]}
+    for group in ("dev", "publish"):
+        required |= {
+            re.split(r"[<>=]", n, maxsplit=1)[0].strip().lower()
+            for n in project.get("optional-dependencies", {}).get(group, [])
+        }
+    header = (ROOT / JOB_SCRIPT).read_text(encoding="utf-8").split("# ///")[1]
+    declared = {m.group(1).lower() for m in re.finditer(r'"\s*([A-Za-z0-9_.-]+)\s*[<>=]', header)}
+    assert required <= declared
+
+
+def test_manifest_matches_the_recipe():
+    from recipe.build import PIT_DELTA_NAME
+
+    manifest = json.loads((ROOT / "manifest.json").read_text(encoding="utf-8"))
+    assert manifest["bundle_storage_data"]["table_uri"].endswith(PIT_DELTA_NAME)
+    assert manifest["source"]["schedule"] == DEFAULT_SCHEDULE
+
+
+def test_schedule_runs_after_the_dataset_it_reads():
+    """Derived entirely from company-fundamentals, which rebuilds at 07:10."""
+    hour, minute = int(DEFAULT_SCHEDULE.split()[1]), int(DEFAULT_SCHEDULE.split()[0])
+    assert (hour, minute) > (7, 10), DEFAULT_SCHEDULE
+
+
+def test_job_specs_can_be_built():
+    """A missing import in hf_jobs fails only when someone schedules the job."""
+    from recipe.hf_jobs import backfill_spec, job_secrets, update_spec
+
+    for spec in (update_spec(repo_id="ZipLime/corporate-actions"),
+                 backfill_spec(repo_id="ZipLime/corporate-actions")):
+        assert spec.script_url.endswith(JOB_SCRIPT)
+        assert spec.script_args
+    assert set(job_secrets(hf_token="x")) == {"HF_TOKEN"}