Spaces:

chimezie90
/

figure-skating-coach

Sleeping

App Files Files Community

skating-coach-deploy commited on Jun 18

Commit

43bbe2b

1 Parent(s): 51da90a

deploy: sync web demo ff7cc29

Browse files

Files changed (7) hide show

Dockerfile +5 -3
server/app/api/sessions.py +30 -1
server/app/legal/privacy.html +104 -0
server/app/legal/support.html +55 -0
server/app/main.py +18 -0
server/app/storage/corpus.py +123 -0
server/app/storage/sessions.py +19 -1

Dockerfile CHANGED Viewed

@@ -39,9 +39,11 @@ WORKDIR /app/server
 # Resolve + install runtime deps into an in-project .venv.
 RUN uv sync --no-dev
-# HF Spaces injects $PORT (default 7860). Session scratch goes to a writable dir.
-ENV PORT=7860 \
-    SKATING_COACH_DATA_DIR=/home/app/skating-coach-data
 EXPOSE 7860
 CMD ["sh", "-c", "uv run --no-dev uvicorn app.main:app --host 0.0.0.0 --port ${PORT:-7860}"]

 # Resolve + install runtime deps into an in-project .venv.
 RUN uv sync --no-dev
+# HF Spaces injects $PORT (default 7860). Data dir is auto-resolved in
+# storage/sessions.py: HF persistent storage at /data when mounted (durable —
+# survives Space restarts, for the F1 corpus + events), else an ephemeral /tmp
+# dir. Set SKATING_COACH_DATA_DIR to override.
+ENV PORT=7860
 EXPOSE 7860
 CMD ["sh", "-c", "uv run --no-dev uvicorn app.main:app --host 0.0.0.0 --port ${PORT:-7860}"]

server/app/api/sessions.py CHANGED Viewed

@@ -19,7 +19,7 @@ from fastapi.responses import FileResponse
 from pydantic import BaseModel, Field
 from app.pipeline import PipelineError, run_pipeline
-from app.storage import Session, SessionStatus, get_store
 log = logging.getLogger(__name__)
 router = APIRouter(prefix="/api/sessions", tags=["sessions"])
@@ -186,6 +186,35 @@ async def get_session(session_id: str) -> dict:
     return _serialize_session(session)
 @router.get("/{session_id}/annotated.mp4")
 async def get_annotated_video(session_id: str) -> FileResponse:
     session = get_store().get(session_id)

 from pydantic import BaseModel, Field
 from app.pipeline import PipelineError, run_pipeline
+from app.storage import Session, SessionStatus, corpus, get_store
 log = logging.getLogger(__name__)
 router = APIRouter(prefix="/api/sessions", tags=["sessions"])
     return _serialize_session(session)
+class FeedbackIn(BaseModel):
+    """F1 trust-flywheel: the skater's one-tap verdict on a review."""
+    install_id: str = Field(min_length=8, max_length=64)
+    verdict: str = Field(pattern=r"^(right|wrong)$")
+    # What it actually was, when the skater corrects us ("wrong"). Free text.
+    said: str | None = Field(default=None, max_length=120)
+    # Explicit opt-in to keep this clip for the eval corpus (internal-only).
+    retain_clip: bool = False
+@router.post("/{session_id}/feedback")
+async def submit_feedback(session_id: str, fb: FeedbackIn) -> dict[str, bool]:
+    """Record a review verdict + optional correction, and (on opt-in) retain the
+    clip for the eval corpus. Tolerant of an expired session — the correction is
+    always logged; only the clip copy needs the session to still hold a file, so
+    this never 404s (the anonymous verdict already rode the M1 event stream)."""
+    session = get_store().get(session_id)
+    retained = corpus.record_feedback(
+        install_id=fb.install_id,
+        session_id=session_id,
+        verdict=fb.verdict,
+        said=fb.said,
+        retain_clip=fb.retain_clip,
+        session=session,
+    )
+    return {"recorded": True, "retained": retained}
 @router.get("/{session_id}/annotated.mp4")
 async def get_annotated_video(session_id: str) -> FileResponse:
     session = get_store().get(session_id)

server/app/legal/privacy.html ADDED Viewed

	@@ -0,0 +1,104 @@

+<!doctype html><html><head><meta charset='utf-8'><title>privacy_policy</title><style>
+body{font:15px/1.6 -apple-system,Helvetica,sans-serif;color:#1b2330;max-width:960px;margin:40px auto;padding:0 24px;background:#faf7f2}
+h1{color:#1b2330;border-bottom:3px solid #e8604c;padding-bottom:8px}
+h2{color:#1b2330;margin-top:2em} h3{color:#e8604c;margin-top:1.8em}
+table{border-collapse:collapse;width:100%;font-size:13.5px;background:#fff;box-shadow:0 1px 3px rgba(0,0,0,.08)}
+th,td{border:1px solid #e3ded6;padding:7px 10px;text-align:left;vertical-align:top}
+th{background:#1b2330;color:#fff} tr:nth-child(even){background:#f6f2ea}
+code{background:#eee9e0;padding:1px 5px;border-radius:4px;font-size:12.5px}
+strong{color:#b3402f} li{margin:3px 0}
+blockquote{border-left:3px solid #e8604c;margin-left:0;padding-left:14px;color:#555}
+</style></head><body><h1>Glide — Privacy Policy</h1>
+<p><em>Last updated: 18 June 2026</em></p>
+<p>Glide ("Glide", "we", "us") is a figure-skating coaching app that analyzes a
+short video of your skating and shows you technique feedback. This policy
+explains exactly what data the app handles, why, and the choices you have. It is
+written to describe what the app <strong>actually does today</strong> — no more, no less.</p>
+<h2>The short version</h2>
+<ul>
+<li>We do <strong>not</strong> ask you to create an account. There is no name, email, or login.</li>
+<li>When you ask for a review, your <strong>video clip is uploaded to our server</strong> to be
+  analyzed, then the coaching result is sent back to your phone.</li>
+<li>Your past reviews are stored <strong>on your device</strong>, not on our servers.</li>
+<li>The only identifier we use is a <strong>random, anonymous install ID</strong> so we can
+  count app usage. It is not tied to you, your device, or any other service.</li>
+<li>You can <strong>delete all your reviews from inside the app</strong> at any time.</li>
+<li>We do <strong>not</strong> sell data, run third-party ad/analytics SDKs, or track you across
+  other apps or websites.</li>
+</ul>
+<h2>What we collect and why</h2>
+<h3>1. The video you submit for a review</h3>
+<p>When you record or import a clip and ask for a review, the app uploads that clip
+to our coaching server (hosted on Hugging Face), which runs pose analysis and an
+AI critique and returns the result.</p>
+<ul>
+<li><strong>What it may contain:</strong> you, and anyone else who happens to be in frame
+  (rinks are public — bystanders, other skaters, and <strong>possibly minors</strong> may
+  appear). Please only film where you are permitted to, and avoid submitting
+  clips that focus on other people, especially children, without their (or a
+  guardian's) permission.</li>
+<li><strong>Retention:</strong> the uploaded source clip is processed and held only on the
+  server's temporary working storage. It is <strong>not</strong> placed in a durable
+  database, and it is cleared when the server restarts (which happens routinely).
+  Clips submitted via a pasted link are deleted from the server immediately after
+  processing. We are not building a permanent library of your clips.</li>
+<li><strong>On your device:</strong> the finished review (the clip plus the coaching) is saved
+  locally on your phone so you can reopen it. This local copy never leaves your
+  device unless you explicitly share it.</li>
+</ul>
+<h3>2. Anonymous usage events</h3>
+<p>To understand whether the app is useful (e.g. how long a review takes, how often
+people come back), the app sends small, anonymous events to our server — for
+example "app opened", "review ready (took N seconds)". These carry <strong>no personal
+information</strong>. The only identifier is a random UUID generated once on your device
+("install ID"); it is not linked to your identity, Apple ID, advertising ID, or
+any other app.</p>
+<h3>3. "Help improve the coach" (opt-in only)</h3>
+<p>If a review gets your move wrong, you can tell us — and you may <strong>optionally</strong>
+choose to share that one clip so we can use it to improve our analysis. This
+sharing is <strong>off by default</strong> and happens only when you tick the box. Shared
+clips are used internally to test and improve the coaching, are reviewed by a
+person, and are <strong>never</strong> used to train a public model or sold to anyone.</p>
+<h3>4. Profile details you enter (optional, stays on your device)</h3>
+<p>If you enter your height (to convert measurements into real-world units), it is
+stored <strong>only on your device</strong> and is never uploaded.</p>
+<h2>What we do NOT do</h2>
+<ul>
+<li>No accounts, no passwords, no email collection.</li>
+<li>No third-party advertising or analytics SDKs.</li>
+<li>No cross-app or cross-site tracking; we do not use the Advertising Identifier.</li>
+<li>No selling or renting of any data.</li>
+</ul>
+<h2>Camera, microphone, and photo access</h2>
+<ul>
+<li><strong>Camera / microphone:</strong> used only while you are recording a clip to review.</li>
+<li><strong>Photo library:</strong> used only when you pick an existing video to review.</li>
+</ul>
+<p>Audio is captured alongside video when you record, as part of the clip; it is
+not analyzed separately or used for any other purpose.</p>
+<h2>Your choices and controls</h2>
+<ul>
+<li><strong>Delete your data:</strong> open the <strong>Me</strong> tab → <strong>Clear all reviews</strong> to delete
+  every saved review (clip, thumbnail, and result) from your device. You can also
+  delete an individual review from its screen.</li>
+<li><strong>Stop sharing clips:</strong> the "help improve the coach" option is per-review and
+  opt-in; simply leave it unticked.</li>
+<li><strong>Uninstalling</strong> the app removes all locally stored reviews and your install ID.</li>
+</ul>
+<p>To request deletion of a clip you previously chose to share, contact us (below)
+with the approximate date you submitted it.</p>
+<h2>Children</h2>
+<p>Glide is designed for <strong>adult</strong> recreational figure skaters and is not directed
+at children. We do not knowingly collect personal information from children. If
+you believe a clip you submitted contains a child and you would like it removed,
+contact us and we will delete any retained copy.</p>
+<h2>Data security &amp; location</h2>
+<p>Uploads use HTTPS. Coaching analysis runs on Hugging Face and GPU compute on
+Modal; these providers process clips transiently on our behalf to produce your
+review. We do not grant them any other rights to your data.</p>
+<h2>Changes to this policy</h2>
+<p>If this policy changes materially, we will update the "Last updated" date and the
+in-app link. Because the app currently has no account or contact list, we cannot
+notify you individually — please check this page.</p>
+<h2>Contact</h2>
+<p>Questions, or a deletion request: <strong>emmanuel@mexkoy.com</strong></p></body></html>

server/app/legal/support.html ADDED Viewed

	@@ -0,0 +1,55 @@

+<!doctype html><html><head><meta charset='utf-8'><title>support</title><style>
+body{font:15px/1.6 -apple-system,Helvetica,sans-serif;color:#1b2330;max-width:960px;margin:40px auto;padding:0 24px;background:#faf7f2}
+h1{color:#1b2330;border-bottom:3px solid #e8604c;padding-bottom:8px}
+h2{color:#1b2330;margin-top:2em} h3{color:#e8604c;margin-top:1.8em}
+table{border-collapse:collapse;width:100%;font-size:13.5px;background:#fff;box-shadow:0 1px 3px rgba(0,0,0,.08)}
+th,td{border:1px solid #e3ded6;padding:7px 10px;text-align:left;vertical-align:top}
+th{background:#1b2330;color:#fff} tr:nth-child(even){background:#f6f2ea}
+code{background:#eee9e0;padding:1px 5px;border-radius:4px;font-size:12.5px}
+strong{color:#b3402f} li{margin:3px 0}
+blockquote{border-left:3px solid #e8604c;margin-left:0;padding-left:14px;color:#555}
+</style></head><body><h1>Glide — Support</h1>
+<p><em>Glide is an AI figure-skating coach: film a field move, get the one fix drawn
+on your body in seconds.</em></p>
+<h2>Contact</h2>
+<ul>
+<li><strong>Email:</strong> emmanuel@mexkoy.com</li>
+<li>We're a tiny team building this with early skaters — real replies, usually
+  within a couple of days.</li>
+</ul>
+<h2>What Glide does</h2>
+<p>Record or import a short clip of a <strong>field move</strong> — a spiral, edge, turn, spin,
+stroking, a glide hold — tap the skater that's you, and Glide analyzes your body
+mechanics and shows you what to work on, traced onto your own video.</p>
+<p>It coaches the things one phone camera can honestly see: extension, posture,
+timing, steadiness, hold duration. When it can't be sure what a move was, it
+shows you the <strong>measurements</strong> instead of guessing a name.</p>
+<h2>What Glide does NOT do (yet)</h2>
+<ul>
+<li><strong>Jumps.</strong> A single phone angle can't reliably judge airborne rotation, so
+  Glide stays out of jumps on purpose rather than guess.</li>
+<li><strong>Edge depth / blade tracing.</strong> Sub-blade detail isn't visible from a phone;
+  we coach the body, not the ice.</li>
+</ul>
+<h2>Tips for the best review</h2>
+<ul>
+<li>Film from roughly a <strong>45° angle</strong> to your path (not flat side-on or head-on),
+  with your <strong>whole body in frame</strong>.</li>
+<li>Keep the clip short (a single element).</li>
+<li>Good light helps the tracker follow you.</li>
+</ul>
+<h2>Common questions</h2>
+<p><strong>Do I need an account?</strong> No. There's no sign-up — just record and review.</p>
+<p><strong>Where do my videos go?</strong> Your finished reviews are stored on your phone. The
+clip is briefly uploaded to our server to be analyzed and is not kept in a
+permanent database. See the <a href="/privacy">Privacy Policy</a>.</p>
+<p><strong>How do I delete my reviews?</strong> Me tab → <strong>Clear all reviews</strong>, or delete a
+single review from its screen.</p>
+<p><strong>It got my move wrong.</strong> Tap <strong>"Did we get your move right?" → No</strong> on the
+review and tell us what it was — that's the most useful thing you can send us,
+and it directly improves the coach. You can optionally share that clip to help.</p>
+<p><strong>The review failed or said my session expired.</strong> Tap <strong>Try again</strong> — it
+re-sends your clip. If it keeps failing, check your connection or try a shorter
+clip, and email us if it persists.</p>
+<h2>Privacy</h2>
+<p>See the full <a href="/privacy">Privacy Policy</a>.</p></body></html>

server/app/main.py CHANGED Viewed

@@ -2,6 +2,8 @@
 Routes:
     /                — single-page demo frontend
     /api/sessions    — upload / poll / fetch annotated video
     /api/events      — anonymous client instrumentation (batched, JSONL per day)
     /api/warmup      — fire-and-forget pre-warm of the Modal GPU pose backend
@@ -32,6 +34,7 @@ app.include_router(sessions_router)
 app.include_router(events_router)
 WEB_DIR = Path(__file__).parent / "web"
 @app.get("/healthz")
@@ -39,6 +42,21 @@ def healthz() -> dict[str, str]:
     return {"status": "ok"}
 # /api/warmup — pre-warm the Modal T4 pose backend. Cold start is ~30-90s vs
 # ~4s warm inference, so the iOS client fires this the moment the user starts
 # recording / picking a clip; by upload time the container is already up.

 Routes:
     /                — single-page demo frontend
+    /privacy         — privacy policy (also the App Store / TestFlight URL)
+    /support         — support page
     /api/sessions    — upload / poll / fetch annotated video
     /api/events      — anonymous client instrumentation (batched, JSONL per day)
     /api/warmup      — fire-and-forget pre-warm of the Modal GPU pose backend
 app.include_router(events_router)
 WEB_DIR = Path(__file__).parent / "web"
+LEGAL_DIR = Path(__file__).parent / "legal"
 @app.get("/healthz")
     return {"status": "ok"}
+# Legal pages — the privacy URL is required by App Store review + external
+# TestFlight metadata once any data is collected. Served from the app server so
+# the URL is stable HTTPS (the iOS GlideLinks point here). Source of truth is
+# docs/legal/*.md; server/app/legal/*.html are the rendered, self-contained
+# (inline-CSS, no external refs) copies.
+@app.get("/privacy")
+def privacy() -> FileResponse:
+    return FileResponse(LEGAL_DIR / "privacy.html", media_type="text/html")
+@app.get("/support")
+def support() -> FileResponse:
+    return FileResponse(LEGAL_DIR / "support.html", media_type="text/html")
 # /api/warmup — pre-warm the Modal T4 pose backend. Cold start is ~30-90s vs
 # ~4s warm inference, so the iOS client fires this the moment the user starts
 # recording / picking a clip; by upload time the container is already up.

server/app/storage/corpus.py ADDED Viewed

	@@ -0,0 +1,123 @@

+"""Opt-in corpus inbox for the F1 trust flywheel.
+When a beta skater says "you got my move wrong" and opts in to share the clip,
+we record their correction and (best-effort) copy the session's source clip into
+`DATA_DIR/corpus_inbox/` so it can be hand-verified and folded into the eval
+corpus — the standing protocol (bug report -> eval clip -> fix -> rerun) gains a
+UI handle instead of relying on chat messages.
+Privacy: clip retention happens ONLY on explicit per-review opt-in, is
+internal-only, and never trains a public model. The verdict itself (right/wrong
++ what it actually was) also rides the anonymous M1 event stream — this module
+is purely the clip-and-correction sidecar that M1 can't carry.
+No database — JSONL append + a file copy, like the events log. Durable storage
+lands with the rest of session persistence in U9.
+"""
+from __future__ import annotations
+import json
+import logging
+import shutil
+import threading
+from datetime import UTC, datetime
+from pathlib import Path
+from typing import TYPE_CHECKING, Any
+from app.storage import sessions
+if TYPE_CHECKING:
+    from app.storage.sessions import Session
+log = logging.getLogger(__name__)
+# Line-level interleave guard for concurrent appends (mirrors events.py).
+_append_lock = threading.Lock()
+def corpus_dir() -> Path:
+    """`DATA_DIR/corpus_inbox` — resolved at call time so tests can repoint."""
+    d = sessions.DATA_DIR / "corpus_inbox"
+    d.mkdir(parents=True, exist_ok=True)
+    return d
+def _source_clip(session: Session | None) -> Path | None:
+    """The best clip to retain for re-eval: the original the skater filmed,
+    falling back to the normalized then the zoom crop. None if the session is
+    gone (non-durable store) or no file survives on disk."""
+    if session is None:
+        return None
+    for path in (session.source_path, session.normalized_path, session.zoom_path):
+        if path is not None and Path(path).exists():
+            return Path(path)
+    return None
+def record_feedback(
+    *,
+    install_id: str,
+    session_id: str,
+    verdict: str,
+    said: str | None,
+    retain_clip: bool,
+    session: Session | None,
+) -> bool:
+    """Append the correction to `corpus_inbox/feedback.jsonl` (always) and, when
+    `retain_clip` is set and a source clip survives on disk, copy it into
+    `corpus_inbox/clips/`. Returns whether a clip was actually retained.
+    The feedback line is written even when the session has expired so the
+    correction is never lost — only the clip copy depends on the session still
+    holding a file.
+    """
+    root = corpus_dir()
+    retained = False
+    clip_name: str | None = None
+    if retain_clip:
+        src = _source_clip(session)
+        if src is not None:
+            clips = root / "clips"
+            clips.mkdir(parents=True, exist_ok=True)
+            clip_name = f"{session_id}{src.suffix}"
+            try:
+                shutil.copy2(src, clips / clip_name)
+                retained = True
+            except OSError:
+                # Best-effort; the correction line still lands. Log it so a
+                # systemic failure (disk full) isn't silent in the corpus pipe.
+                log.warning("corpus clip retain failed for %s", session_id, exc_info=True)
+                retained = False
+                clip_name = None
+    record: dict[str, Any] = {
+        "ts": datetime.now(tz=UTC).isoformat(),
+        "install_id": install_id,
+        "session_id": session_id,
+        "verdict": verdict,
+        "said": said,
+        "declared_move": getattr(session, "declared_move", None),
+        "detected_move": _detected_move(session),
+        "clip": clip_name,
+    }
+    line = json.dumps(record, separators=(",", ":"))
+    with _append_lock:
+        with (root / "feedback.jsonl").open("a", encoding="utf-8") as f:
+            f.write(line + "\n")
+    return retained
+def _detected_move(session: Session | None) -> str | None:
+    """The most specific move the pipeline named for this session, for the
+    sidecar label — best-effort, tolerant of partial/older scorecards."""
+    if session is None:
+        return None
+    moves = session.predicted_moves or []
+    for m in moves:
+        if isinstance(m, dict):
+            name = m.get("move") or m.get("name") or m.get("label")
+            if name:
+                return str(name)
+    return None

server/app/storage/sessions.py CHANGED Viewed

@@ -10,7 +10,25 @@ from enum import StrEnum
 from pathlib import Path
 from typing import Any
-DATA_DIR = Path(os.environ.get("SKATING_COACH_DATA_DIR", "/tmp/skating-coach-data"))
 """Local directory for uploaded + annotated video files."""

 from pathlib import Path
 from typing import Any
+def _resolve_data_dir(persistent_root: Path = Path("/data")) -> Path:
+    """Where uploaded clips, events, and the F1 corpus live.
+    Priority: an explicit ``SKATING_COACH_DATA_DIR`` override → HF persistent
+    storage (``persistent_root``, ``/data``) when it's actually mounted +
+    writable (durable across Space restarts, so the F1 corpus + events survive —
+    enable it in the Space settings) → an ephemeral ``/tmp`` dir (lost on
+    restart; fine pre-scale). ``persistent_root`` is a parameter only so tests
+    can stand in for ``/data``.
+    """
+    override = os.environ.get("SKATING_COACH_DATA_DIR")
+    if override:
+        return Path(override)
+    if persistent_root.is_dir() and os.access(persistent_root, os.W_OK):
+        return persistent_root / "skating-coach"
+    return Path("/tmp/skating-coach-data")
+DATA_DIR = _resolve_data_dir()
 """Local directory for uploaded + annotated video files."""