File size: 11,155 Bytes
297230c
 
 
 
 
62d80bc
297230c
 
62d80bc
 
297230c
 
 
 
 
 
62d80bc
297230c
62d80bc
297230c
 
 
62d80bc
297230c
 
 
 
 
6f3bc03
62d80bc
297230c
 
62d80bc
297230c
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
62d80bc
9e53127
 
 
297230c
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
62d80bc
 
297230c
 
 
 
 
 
 
 
62d80bc
 
 
 
 
 
 
 
 
 
 
 
 
 
297230c
62d80bc
 
297230c
62d80bc
 
 
297230c
 
 
 
 
 
 
 
 
62d80bc
 
 
 
 
 
 
 
 
 
 
 
 
 
9e53127
62d80bc
 
 
 
 
 
 
 
297230c
 
93bf9c7
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
9e53127
297230c
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
62d80bc
297230c
62d80bc
 
 
 
 
 
 
 
 
 
297230c
62d80bc
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
"""Integration tests for headroom learn — using real session data.

These tests run against actual conversation data on the machine.
They verify the full pipeline: scan → analyze → recommend → write.
Tests are skipped if the required data directories don't exist.
The LLM-based analyzer tests require ANTHROPIC_API_KEY.

Key behaviors tested:
- Empty recommendations don't create files
- Real Codex/Claude Code sessions can be scanned
- Skip logic: no file writes when nothing meaningful is found
- Idempotency: running twice produces same output
"""

from __future__ import annotations

import os
from pathlib import Path
from unittest.mock import patch

import pytest

from headroom.learn.analyzer import SessionAnalyzer
from headroom.learn.models import (
    ProjectInfo,
    Recommendation,
    RecommendationTarget,
)
from headroom.learn.scanner import _greedy_path_decode
from headroom.learn.writer import ClaudeCodeWriter, CodexWriter

# =============================================================================
# Writer Tests (no LLM needed)
# =============================================================================


class TestSkipWriteLogic:
    """Verify files are NOT written when there's nothing to write."""

    def test_empty_recommendations_no_write(self, tmp_path):
        """Zero recommendations = zero files written."""
        proj = ProjectInfo(
            name="clean-project",
            project_path=tmp_path / "proj",
            data_path=tmp_path / "data",
        )
        (tmp_path / "proj").mkdir()
        (tmp_path / "data" / "memory").mkdir(parents=True)

        writer = ClaudeCodeWriter()
        result = writer.write([], proj, dry_run=False)

        assert result.files_written == []
        assert not (tmp_path / "proj" / "CLAUDE.md").exists()
        assert not (tmp_path / "data" / "memory" / "MEMORY.md").exists()

    def test_codex_empty_no_write(self, tmp_path):
        """Codex writer also skips on empty recommendations."""
        proj = ProjectInfo(name="clean", project_path=tmp_path, data_path=tmp_path)
        writer = CodexWriter()
        result = writer.write([], proj, dry_run=False)
        assert result.files_written == []
        assert not (tmp_path / "AGENTS.md").exists()


class TestIdempotency:
    """Running learn twice should produce the same output, not duplicate."""

    def test_double_write_replaces_not_appends(self, tmp_path):
        proj = ProjectInfo(name="test", project_path=tmp_path, data_path=tmp_path / "data")
        (tmp_path / "data" / "memory").mkdir(parents=True)

        recs = [
            Recommendation(
                target=RecommendationTarget.CONTEXT_FILE,
                section="Environment",
                content="- Use `uv run python`",
                confidence=0.9,
                evidence_count=10,
            )
        ]

        writer = ClaudeCodeWriter()
        # First write
        writer.write(recs, proj, dry_run=False)
        first_content = (tmp_path / "CLAUDE.md").read_text()

        # Second write (same recs)
        writer.write(recs, proj, dry_run=False)
        second_content = (tmp_path / "CLAUDE.md").read_text()

        # Content should be identical (replaced, not appended)
        assert first_content == second_content
        assert second_content.count("uv run python") == 1


class TestFalsePositiveFiltering:
    """Verify that common false positives don't generate recommendations."""

    def test_sed_output_not_error(self):
        """sed printing file content with 'Error:' in it isn't a real error."""
        from headroom.learn.scanner import is_error_content

        # Normal code output that happens to contain "error" in identifiers
        assert not is_error_content("def handle_error(e):\n    print('ok')")

    def test_real_error_detected(self):
        """Actual errors should be detected."""
        from headroom.learn.scanner import is_error_content

        assert is_error_content("ModuleNotFoundError: No module named 'flask'")
        assert is_error_content(
            "FileNotFoundError: [Errno 2] No such file or directory: '/bad/path'"
        )
        assert is_error_content("bash: unknown_cmd: command not found")


# =============================================================================
# Real-World Integration Tests (skipped if data not present)
# =============================================================================


CLAUDE_DIR = Path.home() / ".claude" / "projects"
CODEX_DIR = Path.home() / ".codex" / "sessions"
HAS_API_KEY = bool(os.environ.get("ANTHROPIC_API_KEY"))
HAS_CODEX_DATA = CODEX_DIR.exists() and (
    any(CODEX_DIR.rglob("*.json")) or any(CODEX_DIR.rglob("*.jsonl"))
)


@pytest.mark.skipif(not CLAUDE_DIR.exists(), reason="No Claude Code data")
class TestClaudeCodeIntegration:
    """Integration tests against real Claude Code session data."""

    def test_scanner_discovers_projects(self):
        from headroom.learn.scanner import ClaudeCodeScanner

        scanner = ClaudeCodeScanner()
        projects = scanner.discover_projects()
        assert len(projects) > 0
        for p in projects:
            assert p.name
            assert p.data_path.exists()

    def test_scanner_extracts_events(self):
        """Scanner should extract events including user messages."""
        from headroom.learn.scanner import ClaudeCodeScanner

        scanner = ClaudeCodeScanner()
        projects = scanner.discover_projects()
        best = max(projects, key=lambda p: len(list(p.data_path.glob("*.jsonl"))))
        sessions = scanner.scan_project(best)
        assert len(sessions) > 0

        # At least some sessions should have events
        sessions_with_events = [s for s in sessions if s.events]
        assert len(sessions_with_events) > 0

    @pytest.mark.skipif(not HAS_API_KEY, reason="No ANTHROPIC_API_KEY")
    def test_full_pipeline_produces_output(self):
        """Scan → analyze on real data produces valid output."""
        from headroom.learn.scanner import ClaudeCodeScanner

        scanner = ClaudeCodeScanner()
        projects = scanner.discover_projects()
        best = max(projects, key=lambda p: len(list(p.data_path.glob("*.jsonl"))))
        sessions = scanner.scan_project(best)
        assert len(sessions) > 0

        analyzer = SessionAnalyzer()
        result = analyzer.analyze(best, sessions)

        assert result.total_calls > 0
        assert result.total_sessions > 0
        assert 0 <= result.failure_rate <= 0.5

    def test_dry_run_writes_nothing(self):
        """Dry run should never create files."""
        from headroom.learn.scanner import ClaudeCodeScanner

        scanner = ClaudeCodeScanner()
        projects = scanner.discover_projects()
        best = max(projects, key=lambda p: len(list(p.data_path.glob("*.jsonl"))))

        # Use mock LLM to avoid needing API key
        mock_response = {
            "context_file_rules": [
                {
                    "section": "Test",
                    "content": "- test rule",
                    "estimated_tokens_saved": 100,
                    "evidence_count": 2,
                }
            ],
            "memory_file_rules": [],
        }
        with patch("headroom.learn.analyzer._call_llm", return_value=mock_response):
            sessions = scanner.scan_project(best)
            result = SessionAnalyzer(model="gpt-4o").analyze(best, sessions)
            recs = result.recommendations

            writer = ClaudeCodeWriter()
            write_result = writer.write(recs, best, dry_run=True)

            assert write_result.dry_run is True
            for fp in write_result.files_written:
                assert "CLAUDE.md" in fp.name or "MEMORY.md" in fp.name


class TestDecodeProjectPath:
    """Unit tests for _greedy_path_decode — covers dot-in-path bug (GitHub.nosync)."""

    def test_dot_in_directory_name(self, tmp_path):
        """Paths with dots (e.g. GitHub.nosync) must decode correctly.

        Claude Code encodes '/' and '.' both as '-', so 'GitHub.nosync'
        becomes 'GitHub-nosync' in the directory name.
        _greedy_path_decode must reconstruct it by trying '.' as a join.
        """
        # base = tmp_path, remaining parts = ["GitHub", "nosync", "myproject"]
        # which came from encoding "GitHub.nosync/myproject" as "GitHub-nosync-myproject"
        (tmp_path / "GitHub.nosync" / "myproject").mkdir(parents=True)
        result = _greedy_path_decode(tmp_path, ["GitHub", "nosync", "myproject"])
        assert result == tmp_path / "GitHub.nosync" / "myproject"

    def test_hyphen_in_directory_name(self, tmp_path):
        """Paths with literal hyphens decode correctly (existing behavior preserved)."""
        (tmp_path / "my-project").mkdir()
        result = _greedy_path_decode(tmp_path, ["my", "project"])
        assert result == tmp_path / "my-project"

    def test_simple_path_no_ambiguity(self, tmp_path):
        """Plain paths with no special chars still decode correctly."""
        (tmp_path / "myproject").mkdir()
        result = _greedy_path_decode(tmp_path, ["myproject"])
        assert result == tmp_path / "myproject"

    def test_dot_preferred_over_slash_when_slash_missing(self, tmp_path):
        """When GitHub/nosync doesn't exist but GitHub.nosync does, use dot."""
        # Only create the dot version, not the slash version
        (tmp_path / "GitHub.nosync").mkdir()
        result = _greedy_path_decode(tmp_path, ["GitHub", "nosync"])
        assert result == tmp_path / "GitHub.nosync"


@pytest.mark.skipif(not HAS_CODEX_DATA, reason="No Codex data")
class TestCodexIntegration:
    """Integration tests against real Codex session data."""

    def test_scanner_discovers_sessions(self):
        from headroom.learn.scanner import CodexScanner

        scanner = CodexScanner()
        projects = scanner.discover_projects()
        assert len(projects) == 1  # Codex returns one "project"

    def test_full_pipeline(self):
        """Full pipeline on real Codex data."""
        from headroom.learn.scanner import CodexScanner

        scanner = CodexScanner()
        projects = scanner.discover_projects()
        sessions = scanner.scan_project(projects[0])

        assert len(sessions) > 0

        # Codex has only Bash tool (shell)
        all_tools = {tc.name for s in sessions for tc in s.tool_calls}
        assert "Bash" in all_tools

    def test_codex_writer_targets_agents_md(self, tmp_path):
        """Codex writer should target AGENTS.md, not CLAUDE.md."""
        proj = ProjectInfo(name="codex-test", project_path=tmp_path, data_path=tmp_path)
        recs = [
            Recommendation(
                target=RecommendationTarget.CONTEXT_FILE,
                section="Commands",
                content="- Use npm run test",
                confidence=0.9,
                evidence_count=5,
            )
        ]

        writer = CodexWriter()
        result = writer.write(recs, proj, dry_run=True)
        for fp in result.files_written:
            assert fp.name in ("AGENTS.md", "instructions.md")
            assert "CLAUDE.md" not in fp.name