Spaces:
Build error
Build error
File size: 18,822 Bytes
a451bf7 10d6c83 a451bf7 10d6c83 a451bf7 0e85550 a451bf7 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 | """Tests for ReadLifecycleManager - event-driven Read lifecycle management.
Tests covering:
- Disabled by default (backward compatibility)
- Stale detection (file edited after Read)
- Superseded detection (file re-Read)
- Fresh Reads untouched
- Multiple files and complex chains
- OpenAI and Anthropic message formats
- CCR store integration
- Size gating
"""
import json
from headroom.config import ReadLifecycleConfig
from headroom.transforms.read_lifecycle import (
ReadLifecycleManager,
)
# =============================================================================
# Helpers
# =============================================================================
def make_openai_read(tool_call_id: str, file_path: str) -> dict:
"""Create an OpenAI-format assistant message with a Read tool call."""
return {
"role": "assistant",
"content": None,
"tool_calls": [
{
"id": tool_call_id,
"type": "function",
"function": {
"name": "Read",
"arguments": json.dumps({"file_path": file_path}),
},
}
],
}
def make_openai_edit(tool_call_id: str, file_path: str) -> dict:
"""Create an OpenAI-format assistant message with an Edit tool call."""
return {
"role": "assistant",
"content": None,
"tool_calls": [
{
"id": tool_call_id,
"type": "function",
"function": {
"name": "Edit",
"arguments": json.dumps(
{
"file_path": file_path,
"old_string": "old",
"new_string": "new",
}
),
},
}
],
}
def make_openai_write(tool_call_id: str, file_path: str) -> dict:
"""Create an OpenAI-format assistant message with a Write tool call."""
return {
"role": "assistant",
"content": None,
"tool_calls": [
{
"id": tool_call_id,
"type": "function",
"function": {
"name": "Write",
"arguments": json.dumps({"file_path": file_path, "content": "new content"}),
},
}
],
}
def make_openai_tool_result(tool_call_id: str, content: str) -> dict:
"""Create an OpenAI-format tool result message."""
return {
"role": "tool",
"tool_call_id": tool_call_id,
"content": content,
}
def make_anthropic_read(tool_call_id: str, file_path: str) -> dict:
"""Create an Anthropic-format assistant message with a Read tool call."""
return {
"role": "assistant",
"content": [
{
"type": "tool_use",
"id": tool_call_id,
"name": "Read",
"input": {"file_path": file_path},
}
],
}
def make_anthropic_edit(tool_call_id: str, file_path: str) -> dict:
"""Create an Anthropic-format assistant message with an Edit tool call."""
return {
"role": "assistant",
"content": [
{
"type": "tool_use",
"id": tool_call_id,
"name": "Edit",
"input": {
"file_path": file_path,
"old_string": "old",
"new_string": "new",
},
}
],
}
def make_anthropic_tool_result(tool_call_id: str, content: str) -> dict:
"""Create an Anthropic-format user message with a tool_result block."""
return {
"role": "user",
"content": [
{
"type": "tool_result",
"tool_use_id": tool_call_id,
"content": content,
}
],
}
LARGE_CONTENT = "x" * 2000 # Well above min_size_bytes
SMALL_CONTENT = "tiny" # Below min_size_bytes
# =============================================================================
# Tests
# =============================================================================
class TestReadLifecycleDisabled:
"""Verify backward compatibility when disabled."""
def test_disabled_when_explicitly_off(self):
"""Explicitly disabled config: no changes to messages."""
config = ReadLifecycleConfig(enabled=False)
assert config.enabled is False
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
]
result = mgr.apply(messages)
assert result.messages is messages # Same object, not copied
assert result.reads_total == 0
assert result.transforms_applied == []
def test_enabled_by_default(self):
"""Default config has lifecycle enabled."""
config = ReadLifecycleConfig()
assert config.enabled is True
class TestStaleDetection:
"""Read outputs become stale when the file is subsequently edited."""
def test_read_then_edit_makes_stale(self):
"""Read(A) → Edit(A): Read becomes stale."""
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_edit("e1", "/src/app.py"),
make_openai_tool_result("e1", "edit success"),
]
result = mgr.apply(messages)
assert result.reads_stale == 1
assert result.reads_fresh == 0
# Read content should be replaced with marker
tool_result = result.messages[1]
assert "stale" in tool_result["content"].lower()
assert "/src/app.py" in tool_result["content"]
assert "hash=" in tool_result["content"]
def test_write_makes_read_stale(self):
"""Read(A) → Write(A): Read becomes stale."""
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_write("w1", "/src/app.py"),
make_openai_tool_result("w1", "write success"),
]
result = mgr.apply(messages)
assert result.reads_stale == 1
assert "stale" in result.messages[1]["content"].lower()
def test_edit_different_file_not_stale(self):
"""Read(A) → Edit(B): Read(A) stays fresh."""
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_edit("e1", "/src/other.py"),
make_openai_tool_result("e1", "edit success"),
]
result = mgr.apply(messages)
assert result.reads_stale == 0
assert result.reads_fresh == 1
assert result.messages[1]["content"] == LARGE_CONTENT
def test_multiple_reads_all_stale(self):
"""Read(A) × 3 → Edit(A): all 3 Reads become stale."""
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_read("r2", "/src/app.py"),
make_openai_tool_result("r2", LARGE_CONTENT + "_v2"),
make_openai_read("r3", "/src/app.py"),
make_openai_tool_result("r3", LARGE_CONTENT + "_v3"),
make_openai_edit("e1", "/src/app.py"),
make_openai_tool_result("e1", "edit success"),
]
result = mgr.apply(messages)
# All 3 reads are stale (edit happened after all of them)
assert result.reads_stale == 3
assert result.reads_fresh == 0
def test_compress_stale_disabled(self):
"""compress_stale=False: stale Reads are not replaced."""
config = ReadLifecycleConfig(enabled=True, compress_stale=False)
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_edit("e1", "/src/app.py"),
make_openai_tool_result("e1", "edit success"),
]
result = mgr.apply(messages)
# With compress_stale=False but compress_superseded=True,
# Read is superseded by nothing (only one read), and not stale → fresh
assert result.reads_fresh == 1
assert result.messages[1]["content"] == LARGE_CONTENT
class TestSupersededDetection:
"""Read outputs become superseded when the same file is re-Read."""
def test_reread_makes_superseded(self):
"""Read(A) → Read(A): first Read becomes superseded."""
config = ReadLifecycleConfig(enabled=True, compress_superseded=True)
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_read("r2", "/src/app.py"),
make_openai_tool_result("r2", LARGE_CONTENT + "_updated"),
]
result = mgr.apply(messages)
assert result.reads_superseded == 1
assert result.reads_fresh == 1
# First read replaced, second read untouched
assert "superseded" in result.messages[1]["content"].lower()
assert result.messages[3]["content"] == LARGE_CONTENT + "_updated"
def test_compress_superseded_disabled(self):
"""compress_superseded=False: superseded Reads not replaced."""
config = ReadLifecycleConfig(enabled=True, compress_superseded=False)
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_read("r2", "/src/app.py"),
make_openai_tool_result("r2", LARGE_CONTENT + "_updated"),
]
result = mgr.apply(messages)
# Both reads are fresh (superseded detection disabled)
assert result.reads_fresh == 2
assert result.messages[1]["content"] == LARGE_CONTENT
class TestFreshReads:
"""Fresh Reads must never be modified."""
def test_single_read_stays_fresh(self):
"""One Read, no Edit: stays fresh."""
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
]
result = mgr.apply(messages)
assert result.reads_fresh == 1
assert result.reads_stale == 0
assert result.reads_superseded == 0
assert result.messages[1]["content"] == LARGE_CONTENT
def test_read_edit_read_chain(self):
"""Read(A) → Edit(A) → Read(A): first stale, second fresh."""
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_edit("e1", "/src/app.py"),
make_openai_tool_result("e1", "edit success"),
make_openai_read("r2", "/src/app.py"),
make_openai_tool_result("r2", LARGE_CONTENT + "_v2"),
]
result = mgr.apply(messages)
# First read: stale (edit happened after) AND superseded (re-read after)
# → classified as stale (stale takes priority)
assert result.reads_stale == 1
# Second read: fresh (latest, no edit after)
assert result.reads_fresh == 1
assert "stale" in result.messages[1]["content"].lower()
assert result.messages[5]["content"] == LARGE_CONTENT + "_v2"
class TestMultipleFiles:
"""Lifecycle management across multiple files."""
def test_independent_files(self):
"""Read(A) → Edit(A) → Read(B): A stale, B fresh."""
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_edit("e1", "/src/app.py"),
make_openai_tool_result("e1", "edit success"),
make_openai_read("r2", "/src/utils.py"),
make_openai_tool_result("r2", LARGE_CONTENT + "_utils"),
]
result = mgr.apply(messages)
assert result.reads_stale == 1
assert result.reads_fresh == 1
assert "stale" in result.messages[1]["content"].lower()
assert result.messages[5]["content"] == LARGE_CONTENT + "_utils"
class TestSizeGating:
"""Small Read outputs should be skipped."""
def test_small_read_not_replaced(self):
"""Read output below min_size_bytes: not replaced even if stale."""
config = ReadLifecycleConfig(enabled=True, min_size_bytes=512)
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", SMALL_CONTENT), # 4 bytes
make_openai_edit("e1", "/src/app.py"),
make_openai_tool_result("e1", "edit success"),
]
result = mgr.apply(messages)
# Stale but too small to replace
assert result.messages[1]["content"] == SMALL_CONTENT
class TestAnthropicFormat:
"""Lifecycle works with Anthropic message format."""
def test_anthropic_stale_read(self):
"""Anthropic format: Read(A) → Edit(A): Read becomes stale."""
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config)
messages = [
make_anthropic_read("r1", "/src/app.py"),
make_anthropic_tool_result("r1", LARGE_CONTENT),
make_anthropic_edit("e1", "/src/app.py"),
make_anthropic_tool_result("e1", "edit success"),
]
result = mgr.apply(messages)
assert result.reads_stale == 1
# Check the tool_result block inside the user message was replaced
user_msg = result.messages[1]
tool_result_block = user_msg["content"][0]
assert "stale" in tool_result_block["content"].lower()
assert "hash=" in tool_result_block["content"]
def test_anthropic_fresh_read(self):
"""Anthropic format: single Read stays fresh."""
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config)
messages = [
make_anthropic_read("r1", "/src/app.py"),
make_anthropic_tool_result("r1", LARGE_CONTENT),
]
result = mgr.apply(messages)
assert result.reads_fresh == 1
user_msg = result.messages[1]
assert user_msg["content"][0]["content"] == LARGE_CONTENT
class TestCCRStoreIntegration:
"""Lifecycle manager stores originals in CCR."""
def test_original_stored_in_ccr(self):
"""When a Read is replaced, original content is stored in CCR."""
class MockStore:
def __init__(self):
self.stored = []
def store(self, **kwargs):
self.stored.append(kwargs)
return "mock_hash_1234567890ab"
mock_store = MockStore()
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config, compression_store=mock_store)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_edit("e1", "/src/app.py"),
make_openai_tool_result("e1", "edit success"),
]
result = mgr.apply(messages)
assert len(mock_store.stored) == 1
assert mock_store.stored[0]["original"] == LARGE_CONTENT
assert mock_store.stored[0]["tool_name"] == "Read"
assert "mock_hash_1234567890ab" in result.messages[1]["content"]
assert result.ccr_hashes == ["mock_hash_1234567890ab"]
def test_no_store_uses_content_hash(self):
"""Without CCR store, marker uses content-derived hash."""
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config, compression_store=None)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_edit("e1", "/src/app.py"),
make_openai_tool_result("e1", "edit success"),
]
result = mgr.apply(messages)
assert "hash=" in result.messages[1]["content"]
class TestTransformTracking:
"""Lifecycle transforms are tracked correctly."""
def test_transforms_recorded(self):
"""Each replacement generates a transform entry."""
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config)
messages = [
make_openai_read("r1", "/src/app.py"),
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_read("r2", "/src/app.py"),
make_openai_tool_result("r2", LARGE_CONTENT),
make_openai_edit("e1", "/src/app.py"),
make_openai_tool_result("e1", "done"),
]
result = mgr.apply(messages)
stale_transforms = [t for t in result.transforms_applied if "stale" in t]
assert len(stale_transforms) == 2 # Both reads are stale
class TestNoFilePathHandling:
"""Reads without parseable file_path should be left alone."""
def test_read_without_file_path(self):
"""Read with no file_path in arguments: treated as unknown, not matched."""
config = ReadLifecycleConfig(enabled=True)
mgr = ReadLifecycleManager(config)
messages = [
{
"role": "assistant",
"content": None,
"tool_calls": [
{
"id": "r1",
"type": "function",
"function": {"name": "Read", "arguments": "{}"},
}
],
},
make_openai_tool_result("r1", LARGE_CONTENT),
make_openai_edit("e1", "/src/app.py"),
make_openai_tool_result("e1", "done"),
]
result = mgr.apply(messages)
# Can't match file_path, so Read is not classified at all
assert result.reads_total == 0
assert result.messages[1]["content"] == LARGE_CONTENT
|