Spaces:
Running
Running
solidprivacy-nl commited on
Commit Β·
1c37dba
1
Parent(s): ff8321f
Close v13.2 Scrub Key import UI workpackage
Browse files- WORKPACKAGES.md +31 -18
WORKPACKAGES.md
CHANGED
|
@@ -227,17 +227,9 @@ Outcome:
|
|
| 227 |
|
| 228 |
---
|
| 229 |
|
| 230 |
-
## Active workpackage
|
| 231 |
-
|
| 232 |
### WP6 β v13.2 Scrub Key import/reload UI integration
|
| 233 |
|
| 234 |
-
Status:
|
| 235 |
-
|
| 236 |
-
Goal:
|
| 237 |
-
|
| 238 |
-
- Add UI support for loading a previously downloaded Scrub Key JSON file.
|
| 239 |
-
- Validate imported keys before loading their mappings into the current replacement/review workflow.
|
| 240 |
-
- Keep import/reload local and separate from deterministic reinsert or AI-output workflows.
|
| 241 |
|
| 242 |
Implemented files:
|
| 243 |
|
|
@@ -246,6 +238,7 @@ Implemented files:
|
|
| 246 |
- `WORKPACKAGES.md`
|
| 247 |
- `CHANGELOG.md`
|
| 248 |
- `handover/workpackages/20260607_1645_v13_2_scrub_key_import_ui.md`
|
|
|
|
| 249 |
|
| 250 |
Implemented behavior:
|
| 251 |
|
|
@@ -256,17 +249,34 @@ Implemented behavior:
|
|
| 256 |
- Loads validated mapping rows into the current replacement table only after the visible `Valideer en laad Scrub Key` user action.
|
| 257 |
- Preserves the existing `Download Scrub Key (.json)` export block.
|
| 258 |
|
| 259 |
-
Validation:
|
| 260 |
|
| 261 |
-
- Local targeted validation
|
| 262 |
- `PYTHONPATH=. pytest -q tests/test_scrub_key.py` β 6 passed.
|
| 263 |
- `PYTHONPATH=. pytest -q tests/test_scrub_key_import.py` β 8 passed.
|
| 264 |
- `PYTHONPATH=. pytest -q tests/test_scrub_key_import_ui_patch.py` β 9 passed.
|
| 265 |
- `PYTHONPATH=. pytest -q tests/test_scrub_key_ui_patch.py` β 12 passed.
|
| 266 |
- `PYTHONPATH=. pytest -q` on the available subset β 35 passed.
|
| 267 |
-
-
|
| 268 |
-
-
|
| 269 |
-
-
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 270 |
|
| 271 |
Boundaries preserved:
|
| 272 |
|
|
@@ -283,7 +293,10 @@ Boundaries preserved:
|
|
| 283 |
|
| 284 |
## Recommended execution order
|
| 285 |
|
| 286 |
-
1.
|
| 287 |
-
|
| 288 |
-
|
| 289 |
-
|
|
|
|
|
|
|
|
|
|
|
|
| 227 |
|
| 228 |
---
|
| 229 |
|
|
|
|
|
|
|
| 230 |
### WP6 β v13.2 Scrub Key import/reload UI integration
|
| 231 |
|
| 232 |
+
Status: completed and formally closed after Actions/sync verification; app verification pending user/coordinator confirmation.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 233 |
|
| 234 |
Implemented files:
|
| 235 |
|
|
|
|
| 238 |
- `WORKPACKAGES.md`
|
| 239 |
- `CHANGELOG.md`
|
| 240 |
- `handover/workpackages/20260607_1645_v13_2_scrub_key_import_ui.md`
|
| 241 |
+
- `handover/workpackages/20260607_1715_v13_2_scrub_key_import_ui_closeout.md`
|
| 242 |
|
| 243 |
Implemented behavior:
|
| 244 |
|
|
|
|
| 249 |
- Loads validated mapping rows into the current replacement table only after the visible `Valideer en laad Scrub Key` user action.
|
| 250 |
- Preserves the existing `Download Scrub Key (.json)` export block.
|
| 251 |
|
| 252 |
+
Validation evidence:
|
| 253 |
|
| 254 |
+
- Local targeted validation recorded in the implementation handover:
|
| 255 |
- `PYTHONPATH=. pytest -q tests/test_scrub_key.py` β 6 passed.
|
| 256 |
- `PYTHONPATH=. pytest -q tests/test_scrub_key_import.py` β 8 passed.
|
| 257 |
- `PYTHONPATH=. pytest -q tests/test_scrub_key_import_ui_patch.py` β 9 passed.
|
| 258 |
- `PYTHONPATH=. pytest -q tests/test_scrub_key_ui_patch.py` β 12 passed.
|
| 259 |
- `PYTHONPATH=. pytest -q` on the available subset β 35 passed.
|
| 260 |
+
- Coordinator evidence after implementation:
|
| 261 |
+
- Tests #89 green β commit `83353e4`.
|
| 262 |
+
- Tests #90 green β commit `4a1ef55`.
|
| 263 |
+
- Sync to Hugging Face Space #104 green β commit `4a1ef55`.
|
| 264 |
+
- Tests #91 green β commit `4d8bfe9`.
|
| 265 |
+
- Sync to Hugging Face Space #105 green β commit `4d8bfe9`.
|
| 266 |
+
- Tests #92 green β commit `ff8321f`.
|
| 267 |
+
- Sync to Hugging Face Space #106 green β commit `ff8321f`.
|
| 268 |
+
|
| 269 |
+
Closeout notes:
|
| 270 |
+
|
| 271 |
+
- GitHub Actions tests are green based on coordinator evidence.
|
| 272 |
+
- GitHub to Hugging Face sync is green based on coordinator evidence.
|
| 273 |
+
- App verification is pending user/coordinator confirmation.
|
| 274 |
+
- Existing Scrub Key JSON export remains in place.
|
| 275 |
+
- Import/reload remains local and uses existing helper logic.
|
| 276 |
+
- The key remains pseudonymization/reversible and must be protected.
|
| 277 |
+
- No AI-output reinsert behavior was added.
|
| 278 |
+
- No automatic document rehydration was added.
|
| 279 |
+
- Existing TXT, CSV, DOCX and PDF downloads were not intentionally changed.
|
| 280 |
|
| 281 |
Boundaries preserved:
|
| 282 |
|
|
|
|
| 293 |
|
| 294 |
## Recommended execution order
|
| 295 |
|
| 296 |
+
1. Ask the coordinator/user to visually verify the Hugging Face app:
|
| 297 |
+
- `Scrub Key laden` visible;
|
| 298 |
+
- import/reload warning visible;
|
| 299 |
+
- existing Scrub Key export still visible;
|
| 300 |
+
- existing downloads still available.
|
| 301 |
+
2. After import/reload is visually verified, implement a deterministic reinsert helper as a separate non-UI workpackage.
|
| 302 |
+
3. Only after deterministic reinsert is stable, consider AI-output reinsert UI.
|