Spaces:
Sleeping
Sleeping
solidprivacy-nl commited on
Commit ·
8b16d7e
1
Parent(s): 950f9f6
Log review summary UI integration
Browse files- CHANGELOG.md +23 -28
CHANGELOG.md
CHANGED
|
@@ -26,20 +26,23 @@ For UI/UX-only work, prefer pure helper modules and tests before touching Stream
|
|
| 26 |
|
| 27 |
---
|
| 28 |
|
| 29 |
-
## v12.5 — Final review summary
|
| 30 |
|
| 31 |
-
Status:
|
| 32 |
|
| 33 |
Purpose:
|
| 34 |
|
| 35 |
-
-
|
| 36 |
-
-
|
| 37 |
-
-
|
|
|
|
| 38 |
|
| 39 |
Files added or changed:
|
| 40 |
|
| 41 |
- `review_summary.py`
|
| 42 |
- `tests/test_review_summary.py`
|
|
|
|
|
|
|
| 43 |
- `WORKPACKAGES.md`
|
| 44 |
- `CHANGELOG.md`
|
| 45 |
|
|
@@ -57,22 +60,24 @@ Main changes:
|
|
| 57 |
- open unchecked candidate rows.
|
| 58 |
- Added conservative include-flag parsing for boolean, numeric and Dutch/string values.
|
| 59 |
- Added status inference from stable status values, Dutch status labels, source fields and manual/remembered entity markers.
|
| 60 |
-
- Added Dutch readiness labels and markdown summary lines
|
|
|
|
|
|
|
| 61 |
|
| 62 |
Testing:
|
| 63 |
|
| 64 |
- Added unit tests for `review_summary.py`.
|
| 65 |
-
-
|
| 66 |
-
-
|
| 67 |
-
- Hugging Face sync
|
| 68 |
|
| 69 |
Intentionally not changed:
|
| 70 |
|
| 71 |
-
- No
|
| 72 |
-
- No edits to `presidio_streamlit.py`.
|
| 73 |
-
- No edits to `fix_streamlit_nested_expanders.py`.
|
| 74 |
- No recognizer changes.
|
| 75 |
-
- No
|
|
|
|
|
|
|
| 76 |
- No Scrub Key or reinsert implementation.
|
| 77 |
- No LLM/cloud feature.
|
| 78 |
|
|
@@ -80,7 +85,7 @@ Intentionally not changed:
|
|
| 80 |
|
| 81 |
## v12.4 — Review guidance text
|
| 82 |
|
| 83 |
-
Status: implemented;
|
| 84 |
|
| 85 |
Purpose:
|
| 86 |
|
|
@@ -110,6 +115,7 @@ Testing:
|
|
| 110 |
|
| 111 |
- Added unit tests for guidance text coverage.
|
| 112 |
- User visually confirmed the guidance block appeared correctly in Hugging Face.
|
|
|
|
| 113 |
|
| 114 |
Intentionally not changed:
|
| 115 |
|
|
@@ -122,7 +128,7 @@ Intentionally not changed:
|
|
| 122 |
|
| 123 |
## Project governance setup
|
| 124 |
|
| 125 |
-
Status: implemented;
|
| 126 |
|
| 127 |
Purpose:
|
| 128 |
|
|
@@ -176,13 +182,7 @@ Main changes:
|
|
| 176 |
- `Vervangen door`
|
| 177 |
- `Type gegeven`
|
| 178 |
- `Zekerheid`
|
| 179 |
-
- Technical and audit-oriented columns are moved out of the primary editing view
|
| 180 |
-
- `Bron`
|
| 181 |
-
- `Reden`
|
| 182 |
-
- `Context`
|
| 183 |
-
- `Technisch type`
|
| 184 |
-
- `Technische score`
|
| 185 |
-
- `Technische bron`
|
| 186 |
- Added a separate `Technische details bij de vervangtabel` expander.
|
| 187 |
- Fixed pandas Index truth-value handling by explicitly converting available columns to list/set.
|
| 188 |
|
|
@@ -226,12 +226,7 @@ Files added or changed:
|
|
| 226 |
|
| 227 |
Main changes:
|
| 228 |
|
| 229 |
-
- Added pure filter helpers with Dutch filter labels
|
| 230 |
-
- `Toon alles`
|
| 231 |
-
- `Alleen controle nodig`
|
| 232 |
-
- `Alleen juridische referenties`
|
| 233 |
-
- `Alleen namen/adressen`
|
| 234 |
-
- `Alleen lage zekerheid`
|
| 235 |
- Added filter groups for legal/admin reference entity types, names and address-like data.
|
| 236 |
- Added low-confidence filtering based on either Dutch confidence label `Laag` or numeric score below `0.60`.
|
| 237 |
- Added tests for all filter modes.
|
|
|
|
| 26 |
|
| 27 |
---
|
| 28 |
|
| 29 |
+
## v12.5 — Final review summary
|
| 30 |
|
| 31 |
+
Status: UI integration implemented; awaiting GitHub Actions, Hugging Face sync and app verification.
|
| 32 |
|
| 33 |
Purpose:
|
| 34 |
|
| 35 |
+
- Show final export readiness before downloads.
|
| 36 |
+
- Make export scope clear before the user downloads files.
|
| 37 |
+
- Warn when candidate rows still need attention.
|
| 38 |
+
- Preserve existing replacement and export semantics.
|
| 39 |
|
| 40 |
Files added or changed:
|
| 41 |
|
| 42 |
- `review_summary.py`
|
| 43 |
- `tests/test_review_summary.py`
|
| 44 |
+
- `tests/test_review_summary_ui_patch.py`
|
| 45 |
+
- `fix_streamlit_nested_expanders.py`
|
| 46 |
- `WORKPACKAGES.md`
|
| 47 |
- `CHANGELOG.md`
|
| 48 |
|
|
|
|
| 60 |
- open unchecked candidate rows.
|
| 61 |
- Added conservative include-flag parsing for boolean, numeric and Dutch/string values.
|
| 62 |
- Added status inference from stable status values, Dutch status labels, source fields and manual/remembered entity markers.
|
| 63 |
+
- Added Dutch readiness labels and markdown summary lines.
|
| 64 |
+
- Integrated the summary into the existing startup UI patch so the app shows `Eindcontrole vóór download` immediately above the download section.
|
| 65 |
+
- Kept the summary advisory only: it displays counts and readiness labels but does not block or alter downloads.
|
| 66 |
|
| 67 |
Testing:
|
| 68 |
|
| 69 |
- Added unit tests for `review_summary.py`.
|
| 70 |
+
- Added a UI patch contract test to verify that the summary helper is imported and displayed before downloads.
|
| 71 |
+
- Local targeted validation before UI integration passed: `PYTHONPATH=. pytest -q tests/test_review_summary.py` → 5 passed.
|
| 72 |
+
- GitHub Actions and Hugging Face sync need confirmation for the UI integration commits.
|
| 73 |
|
| 74 |
Intentionally not changed:
|
| 75 |
|
| 76 |
+
- No direct edit to `presidio_streamlit.py`.
|
|
|
|
|
|
|
| 77 |
- No recognizer changes.
|
| 78 |
+
- No entity-type expansion.
|
| 79 |
+
- No export/download blocking.
|
| 80 |
+
- No change to which rows are included in export.
|
| 81 |
- No Scrub Key or reinsert implementation.
|
| 82 |
- No LLM/cloud feature.
|
| 83 |
|
|
|
|
| 85 |
|
| 86 |
## v12.4 — Review guidance text
|
| 87 |
|
| 88 |
+
Status: implemented; GitHub Actions and Hugging Face sync confirmed green by coordinator; app visually confirmed by user.
|
| 89 |
|
| 90 |
Purpose:
|
| 91 |
|
|
|
|
| 115 |
|
| 116 |
- Added unit tests for guidance text coverage.
|
| 117 |
- User visually confirmed the guidance block appeared correctly in Hugging Face.
|
| 118 |
+
- Coordinator confirmed latest Actions and Hugging Face sync green for the helper/governance commits through `fffd27b`.
|
| 119 |
|
| 120 |
Intentionally not changed:
|
| 121 |
|
|
|
|
| 128 |
|
| 129 |
## Project governance setup
|
| 130 |
|
| 131 |
+
Status: implemented; Actions/sync confirmed green by coordinator through latest governance/helper handover commits.
|
| 132 |
|
| 133 |
Purpose:
|
| 134 |
|
|
|
|
| 182 |
- `Vervangen door`
|
| 183 |
- `Type gegeven`
|
| 184 |
- `Zekerheid`
|
| 185 |
+
- Technical and audit-oriented columns are moved out of the primary editing view.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 186 |
- Added a separate `Technische details bij de vervangtabel` expander.
|
| 187 |
- Fixed pandas Index truth-value handling by explicitly converting available columns to list/set.
|
| 188 |
|
|
|
|
| 226 |
|
| 227 |
Main changes:
|
| 228 |
|
| 229 |
+
- Added pure filter helpers with Dutch filter labels.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 230 |
- Added filter groups for legal/admin reference entity types, names and address-like data.
|
| 231 |
- Added low-confidence filtering based on either Dutch confidence label `Laag` or numeric score below `0.60`.
|
| 232 |
- Added tests for all filter modes.
|