Spaces:
Sleeping
Sleeping
solidprivacy-nl commited on
Commit ·
90acefe
1
Parent(s): d44f95c
Record v12.6 export sanity closeout
Browse files- CHANGELOG.md +44 -75
CHANGELOG.md
CHANGED
|
@@ -26,60 +26,84 @@ For UI/UX-only work, prefer pure helper modules and tests before touching Stream
|
|
| 26 |
|
| 27 |
---
|
| 28 |
|
| 29 |
-
## v12.6 — Export sanity checks
|
| 30 |
|
| 31 |
-
Status:
|
| 32 |
|
| 33 |
Purpose:
|
| 34 |
|
| 35 |
-
-
|
| 36 |
-
-
|
| 37 |
-
- Preserve
|
| 38 |
-
- Keep the warnings advisory only.
|
| 39 |
|
| 40 |
-
Files added or changed:
|
| 41 |
|
| 42 |
-
- `
|
|
|
|
| 43 |
- `tests/test_export_sanity_ui_patch.py`
|
|
|
|
| 44 |
- `WORKPACKAGES.md`
|
| 45 |
- `CHANGELOG.md`
|
|
|
|
| 46 |
- `handover/workpackages/20260607_1445_v12_6_export_sanity_ui.md`
|
|
|
|
| 47 |
|
| 48 |
Main changes:
|
| 49 |
|
| 50 |
-
-
|
| 51 |
-
- Added
|
| 52 |
-
- The UI can show advisory warnings for:
|
| 53 |
- unchecked `Controle nodig` rows;
|
| 54 |
- candidate rows not included;
|
| 55 |
- no replacements selected;
|
| 56 |
- user review still required;
|
| 57 |
- export not guaranteeing full anonymization.
|
| 58 |
-
- Added
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 59 |
|
| 60 |
Testing and verification:
|
| 61 |
|
| 62 |
-
-
|
| 63 |
-
-
|
| 64 |
-
-
|
| 65 |
-
-
|
| 66 |
-
- Hugging Face
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 67 |
|
| 68 |
Intentionally not changed:
|
| 69 |
|
|
|
|
| 70 |
- No direct edit to `presidio_streamlit.py`.
|
| 71 |
- No export/download blocking.
|
| 72 |
- No change to which rows are included in export.
|
| 73 |
- No change to TXT, CSV, DOCX or PDF download logic.
|
| 74 |
-
- No Scrub Key logic added.
|
| 75 |
-
- No reinsert workflow added.
|
| 76 |
- No cloud processing introduced.
|
| 77 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 78 |
---
|
| 79 |
|
| 80 |
## WP Status Reconciliation — WP3/WP4 verification evidence
|
| 81 |
|
| 82 |
-
Status: reconciliation completed; GitHub Actions and Hugging Face sync could not be independently confirmed through the connector.
|
| 83 |
|
| 84 |
Purpose:
|
| 85 |
|
|
@@ -169,61 +193,6 @@ Intentionally not changed:
|
|
| 169 |
|
| 170 |
---
|
| 171 |
|
| 172 |
-
## v12.6 — Export sanity checks helper and tests
|
| 173 |
-
|
| 174 |
-
Status: helper implemented; coordinator reconciled helper verification as green before UI integration.
|
| 175 |
-
|
| 176 |
-
Purpose:
|
| 177 |
-
|
| 178 |
-
- Prepare advisory export sanity-check logic before UI integration.
|
| 179 |
-
- Warn users when review risk remains.
|
| 180 |
-
- Preserve existing export semantics and download behavior.
|
| 181 |
-
|
| 182 |
-
Files added or changed:
|
| 183 |
-
|
| 184 |
-
- `export_sanity.py`
|
| 185 |
-
- `tests/test_export_sanity.py`
|
| 186 |
-
- `WORKPACKAGES.md`
|
| 187 |
-
- `handover/workpackages/20260607_1405_v12_6_export_sanity_helper.md`
|
| 188 |
-
|
| 189 |
-
Main changes:
|
| 190 |
-
|
| 191 |
-
- Added pure helper logic for advisory export readiness checks.
|
| 192 |
-
- Added Dutch user-facing warning text for:
|
| 193 |
-
- unchecked `Controle nodig` rows;
|
| 194 |
-
- candidate rows not included;
|
| 195 |
-
- no replacements selected;
|
| 196 |
-
- user review still required;
|
| 197 |
-
- export not guaranteeing full anonymization.
|
| 198 |
-
- Added readiness labels:
|
| 199 |
-
- `Geen vervangregels gevonden — controleer handmatig`;
|
| 200 |
-
- `Geen vervangingen geselecteerd`;
|
| 201 |
-
- `Controle nodig vóór export`;
|
| 202 |
-
- `Klaar voor export na gebruikerscontrole`.
|
| 203 |
-
- Explicitly preserved helper flags:
|
| 204 |
-
- `blocks_export = False`;
|
| 205 |
-
- `changes_export_semantics = False`.
|
| 206 |
-
- Reused review-summary normalization logic where helpful.
|
| 207 |
-
|
| 208 |
-
Testing:
|
| 209 |
-
|
| 210 |
-
- Added `tests/test_export_sanity.py`.
|
| 211 |
-
- Local targeted validation passed in the WP3 handover:
|
| 212 |
-
- `PYTHONPATH=. pytest -q tests/test_export_sanity.py tests/test_review_summary.py` → 12 passed.
|
| 213 |
-
- Coordinator later reconciled helper verification: `Tests #58` green and `Sync to Hugging Face Space #72` green for commit `b0bf8ae`.
|
| 214 |
-
|
| 215 |
-
Intentionally not changed:
|
| 216 |
-
|
| 217 |
-
- No direct edit to `presidio_streamlit.py`.
|
| 218 |
-
- No direct edit to `fix_streamlit_nested_expanders.py` in the helper-only phase.
|
| 219 |
-
- No change to `review_summary.py`.
|
| 220 |
-
- No export/download blocking.
|
| 221 |
-
- No change to which rows are included in export.
|
| 222 |
-
- No Scrub Key or reinsert implementation.
|
| 223 |
-
- No LLM/cloud feature.
|
| 224 |
-
|
| 225 |
-
---
|
| 226 |
-
|
| 227 |
## v12.5 — Final review summary
|
| 228 |
|
| 229 |
Status: completed and app verified.
|
|
|
|
| 26 |
|
| 27 |
---
|
| 28 |
|
| 29 |
+
## v12.6 — Export sanity checks closeout
|
| 30 |
|
| 31 |
+
Status: completed and administratively closed after coordinator closeout instruction.
|
| 32 |
|
| 33 |
Purpose:
|
| 34 |
|
| 35 |
+
- Close the v12.6 export sanity workpackage after helper and UI integration were completed.
|
| 36 |
+
- Record that the UI warning block is advisory only.
|
| 37 |
+
- Preserve the documented boundary that export/download behavior was not changed.
|
|
|
|
| 38 |
|
| 39 |
+
Files added or changed in the full v12.6 line:
|
| 40 |
|
| 41 |
+
- `export_sanity.py`
|
| 42 |
+
- `tests/test_export_sanity.py`
|
| 43 |
- `tests/test_export_sanity_ui_patch.py`
|
| 44 |
+
- `fix_streamlit_nested_expanders.py`
|
| 45 |
- `WORKPACKAGES.md`
|
| 46 |
- `CHANGELOG.md`
|
| 47 |
+
- `handover/workpackages/20260607_1405_v12_6_export_sanity_helper.md`
|
| 48 |
- `handover/workpackages/20260607_1445_v12_6_export_sanity_ui.md`
|
| 49 |
+
- `handover/workpackages/20260607_1515_v12_6_export_sanity_closeout.md`
|
| 50 |
|
| 51 |
Main changes:
|
| 52 |
|
| 53 |
+
- Added pure helper logic for advisory export readiness checks.
|
| 54 |
+
- Added Dutch user-facing warning text for:
|
|
|
|
| 55 |
- unchecked `Controle nodig` rows;
|
| 56 |
- candidate rows not included;
|
| 57 |
- no replacements selected;
|
| 58 |
- user review still required;
|
| 59 |
- export not guaranteeing full anonymization.
|
| 60 |
+
- Added readiness labels:
|
| 61 |
+
- `Geen vervangregels gevonden — controleer handmatig`;
|
| 62 |
+
- `Geen vervangingen geselecteerd`;
|
| 63 |
+
- `Controle nodig vóór export`;
|
| 64 |
+
- `Klaar voor export na gebruikerscontrole`.
|
| 65 |
+
- Integrated the existing `export_sanity.py` helper into the Streamlit startup patch flow.
|
| 66 |
+
- Added UI text for `Extra exportcontrole` near the existing v12.5 `Eindcontrole vóór download` block.
|
| 67 |
+
- Added patch-level tests to guard that the export sanity helper is wired into the UI patch.
|
| 68 |
+
- Administratively closed WP3C without changing code files.
|
| 69 |
|
| 70 |
Testing and verification:
|
| 71 |
|
| 72 |
+
- Helper validation recorded in WP3A handover:
|
| 73 |
+
- `PYTHONPATH=. pytest -q tests/test_export_sanity.py tests/test_review_summary.py` → 12 passed.
|
| 74 |
+
- Coordinator reconciled helper verification:
|
| 75 |
+
- `Tests #58` green.
|
| 76 |
+
- `Sync to Hugging Face Space #72` green.
|
| 77 |
+
- commit `b0bf8ae`.
|
| 78 |
+
- UI integration commits recorded:
|
| 79 |
+
- `c60b9b4bfa8944e620546ca26a4fe42c287edaa0` — Integrate export sanity warnings into UI patch.
|
| 80 |
+
- `f5158c9faf8e7676cb8403da0b42b0465539acfa` — Add export sanity UI patch tests.
|
| 81 |
+
- `7d043d13096518d5dca6a5f187189fa3a8471627` — Update workpackage status for export sanity UI.
|
| 82 |
+
- `4a84ddb7ca2b298ce2dcdcc5daf8b9f1cc055023` — Add export sanity UI handover.
|
| 83 |
+
- WP3C was administrative closeout only; no new local pytest run was performed by this worker.
|
| 84 |
|
| 85 |
Intentionally not changed:
|
| 86 |
|
| 87 |
+
- No code files changed in WP3C closeout.
|
| 88 |
- No direct edit to `presidio_streamlit.py`.
|
| 89 |
- No export/download blocking.
|
| 90 |
- No change to which rows are included in export.
|
| 91 |
- No change to TXT, CSV, DOCX or PDF download logic.
|
| 92 |
+
- No Scrub Key logic added in v12.6.
|
| 93 |
+
- No reinsert workflow added in v12.6.
|
| 94 |
- No cloud processing introduced.
|
| 95 |
|
| 96 |
+
Outcome:
|
| 97 |
+
|
| 98 |
+
- v12.6 is closed.
|
| 99 |
+
- v12 Review UX is complete through guidance, final review summary and export sanity warnings.
|
| 100 |
+
- Next UI work should move to v13 Scrub Key JSON export only after coordinator approval.
|
| 101 |
+
|
| 102 |
---
|
| 103 |
|
| 104 |
## WP Status Reconciliation — WP3/WP4 verification evidence
|
| 105 |
|
| 106 |
+
Status: reconciliation completed; GitHub Actions and Hugging Face sync could not be independently confirmed through the connector at that time.
|
| 107 |
|
| 108 |
Purpose:
|
| 109 |
|
|
|
|
| 193 |
|
| 194 |
---
|
| 195 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 196 |
## v12.5 — Final review summary
|
| 197 |
|
| 198 |
Status: completed and app verified.
|