Spaces:
Running
Running
solidprivacy-nl commited on
Commit ·
97bc6aa
1
Parent(s): 8cc1b2f
Add handover for v13.6 two-mode UI app closeout
Browse files
handover/workpackages/20260608_0000_v13_6_two_mode_ui_app_closeout.md
ADDED
|
@@ -0,0 +1,133 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Handover — WP12B — v13.6 Two-mode UI app verification closeout
|
| 2 |
+
|
| 3 |
+
Repository: `solidprivacy-nl/scrub`
|
| 4 |
+
Status: completed and app-verified after Actions/sync verification
|
| 5 |
+
|
| 6 |
+
## Summary
|
| 7 |
+
|
| 8 |
+
WP12B administratively closes the v13.6 two-mode UI line.
|
| 9 |
+
|
| 10 |
+
Closed sequence:
|
| 11 |
+
|
| 12 |
+
- WP12 introduced the two-mode UI skeleton.
|
| 13 |
+
- WP12-FIX cleaned up content separation.
|
| 14 |
+
- WP12-FIX2 fixed the generated indentation/runtime error around `Scrub Key laden`.
|
| 15 |
+
- WP12B records successful GitHub Actions, Hugging Face sync and app verification.
|
| 16 |
+
|
| 17 |
+
The previous blocking runtime error was:
|
| 18 |
+
|
| 19 |
+
```text
|
| 20 |
+
IndentationError: unexpected indent
|
| 21 |
+
File "/home/user/app/presidio_streamlit.py", line 380
|
| 22 |
+
st.markdown("**Scrub Key laden**")
|
| 23 |
+
```
|
| 24 |
+
|
| 25 |
+
This is now verified fixed in the app.
|
| 26 |
+
|
| 27 |
+
## Files added
|
| 28 |
+
|
| 29 |
+
- `handover/workpackages/20260608_0000_v13_6_two_mode_ui_app_closeout.md`
|
| 30 |
+
|
| 31 |
+
## Files changed
|
| 32 |
+
|
| 33 |
+
- `WORKPACKAGES.md`
|
| 34 |
+
- `CHANGELOG.md`
|
| 35 |
+
|
| 36 |
+
## Code files changed
|
| 37 |
+
|
| 38 |
+
None.
|
| 39 |
+
|
| 40 |
+
This was a closeout-only workpackage.
|
| 41 |
+
|
| 42 |
+
## Tests
|
| 43 |
+
|
| 44 |
+
No new tests were added or changed in WP12B.
|
| 45 |
+
|
| 46 |
+
Existing technical verification evidence from the coordinator:
|
| 47 |
+
|
| 48 |
+
```text
|
| 49 |
+
Tests #155 green — commit b27d115
|
| 50 |
+
Sync to Hugging Face Space #169 green — commit b27d115
|
| 51 |
+
|
| 52 |
+
Tests #156 green — commit 0e357bb
|
| 53 |
+
Sync to Hugging Face Space #170 green — commit 0e357bb
|
| 54 |
+
|
| 55 |
+
Tests #157 green — commit 268234d
|
| 56 |
+
Sync to Hugging Face Space #171 green — commit 268234d
|
| 57 |
+
```
|
| 58 |
+
|
| 59 |
+
Latest verified WP12-FIX2 commit:
|
| 60 |
+
|
| 61 |
+
```text
|
| 62 |
+
268234d9d1aeb9c82658c4c30702f51cfdd58c96
|
| 63 |
+
```
|
| 64 |
+
|
| 65 |
+
## Validation status
|
| 66 |
+
|
| 67 |
+
GitHub Actions: green based on coordinator evidence.
|
| 68 |
+
Hugging Face sync: green based on coordinator evidence.
|
| 69 |
+
App verification: confirmed by coordinator/user.
|
| 70 |
+
|
| 71 |
+
## App verification status
|
| 72 |
+
|
| 73 |
+
Confirmed.
|
| 74 |
+
|
| 75 |
+
Coordinator/user verified:
|
| 76 |
+
|
| 77 |
+
- The app starts without Script execution error.
|
| 78 |
+
- No `IndentationError` appears.
|
| 79 |
+
- `Originele waarden terugzetten` mode is visible and selectable.
|
| 80 |
+
- In `Originele waarden terugzetten`, the full anonymization workflow is no longer shown above the reinsert flow.
|
| 81 |
+
- `Scrub Key laden` is visible.
|
| 82 |
+
- Scrub Key upload/paste is visible.
|
| 83 |
+
- `Valideer en laad Scrub Key` is visible.
|
| 84 |
+
- Local pasted-text reinsert section is visible.
|
| 85 |
+
- Warning about restored sensitive/confidential values is visible.
|
| 86 |
+
- Local-only / no-AI / no-cloud text is visible.
|
| 87 |
+
- Text field for reinsert is visible.
|
| 88 |
+
- Button `Zet originele waarden lokaal terug` is visible.
|
| 89 |
+
- No TXT upload reinsert UI appears.
|
| 90 |
+
- No DOCX upload reinsert UI appears.
|
| 91 |
+
- No PDF reinsert appears.
|
| 92 |
+
- No AI/cloud behavior appears.
|
| 93 |
+
|
| 94 |
+
Also recorded:
|
| 95 |
+
|
| 96 |
+
- `Anonimiseren` mode remains available.
|
| 97 |
+
- Existing anonymization workflow remains available in `Anonimiseren`.
|
| 98 |
+
- Existing Scrub Key export/import remains available.
|
| 99 |
+
- Existing pasted-text reinsert remains available.
|
| 100 |
+
|
| 101 |
+
## Boundaries preserved
|
| 102 |
+
|
| 103 |
+
- No code files changed.
|
| 104 |
+
- `fix_streamlit_nested_expanders.py` was not changed in WP12B.
|
| 105 |
+
- `presidio_streamlit.py` was not changed.
|
| 106 |
+
- `scrub_key_document_reinsert.py` was not changed.
|
| 107 |
+
- `scrub_key_reinsert.py` was not changed.
|
| 108 |
+
- `scrub_key.py` was not changed.
|
| 109 |
+
- `scrub_key_import.py` was not changed.
|
| 110 |
+
- No test files were changed.
|
| 111 |
+
- No TXT upload reinsert UI added.
|
| 112 |
+
- No DOCX upload reinsert UI added.
|
| 113 |
+
- No PDF reinsert added.
|
| 114 |
+
- No AI calls added.
|
| 115 |
+
- No cloud processing added.
|
| 116 |
+
- No automatic document rehydration added.
|
| 117 |
+
- No existing TXT, CSV, DOCX or PDF scrubbed export/download behavior intentionally changed.
|
| 118 |
+
- No Scrub Key export/import behavior intentionally changed.
|
| 119 |
+
- No secrets, tokens or real personal data stored.
|
| 120 |
+
|
| 121 |
+
## Remaining risks
|
| 122 |
+
|
| 123 |
+
- None for the WP12B closeout itself.
|
| 124 |
+
- Future UI work should remain sequential because `fix_streamlit_nested_expanders.py` and Streamlit workflow state are still sensitive patch areas.
|
| 125 |
+
- WP13 should be started only as a separate workpackage.
|
| 126 |
+
|
| 127 |
+
## Next recommended step
|
| 128 |
+
|
| 129 |
+
```text
|
| 130 |
+
WP13 — v13.7 TXT reinsert upload/download UI
|
| 131 |
+
```
|
| 132 |
+
|
| 133 |
+
WP13 should remain limited to TXT reinsert upload/download UI and must not introduce DOCX upload reinsert UI, PDF reinsert, AI/cloud behavior or export semantic changes.
|