solidprivacy-nl commited on
Commit
b0bf8ae
·
1 Parent(s): fb48aac

Reconcile WP3 and WP4 verification evidence

Browse files
Files changed (1) hide show
  1. CHANGELOG.md +113 -1
CHANGELOG.md CHANGED
@@ -26,9 +26,65 @@ For UI/UX-only work, prefer pure helper modules and tests before touching Stream
26
 
27
  ---
28
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
29
  ## v13.0 — Scrub Key specification and pure model
30
 
31
- Status: implemented; pending GitHub Actions and Hugging Face sync confirmation.
32
 
33
  Purpose:
34
 
@@ -76,6 +132,7 @@ Testing:
76
  - Added `tests/test_scrub_key.py`.
77
  - Local targeted validation passed: `PYTHONPATH=. pytest -q tests/test_scrub_key.py` → 6 passed.
78
  - Tests cover valid key creation, excluded-row omission, required fields, JSON roundtrip, validation errors, and synthetic Dutch legal examples only.
 
79
 
80
  Intentionally not changed:
81
 
@@ -90,6 +147,61 @@ Intentionally not changed:
90
 
91
  ---
92
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
93
  ## v12.5 — Final review summary
94
 
95
  Status: completed and app verified.
 
26
 
27
  ---
28
 
29
+ ## WP Status Reconciliation — WP3/WP4 verification evidence
30
+
31
+ Status: reconciliation completed; GitHub Actions and Hugging Face sync could not be independently confirmed through the connector.
32
+
33
+ Purpose:
34
+
35
+ - Verify and reconcile status for:
36
+ - v12.6 export sanity commits;
37
+ - v13.0 Scrub Key commits, especially `d65364373e4d3612044d8688ac17e11de81c07e5`.
38
+ - Update project control files without changing code or UI behavior.
39
+
40
+ Verification attempted:
41
+
42
+ - WP3/v12.6 commits checked:
43
+ - `5342e0eef663817036e91f823b4389b338b9223c` — Add v12.6 export sanity helper.
44
+ - `704ae03788702ce33263343743a69f8139f16319` — Add v12.6 export sanity tests.
45
+ - `869e3804edf04e0cbdf7ab69b034e7bc707de8c3` — Update workpackage status for export sanity helper.
46
+ - `4d721e3aed3bf28cfdaeb096c0e9cd227885f1a6` — Add v12.6 export sanity handover.
47
+ - WP4/v13.0 target commit checked:
48
+ - `d65364373e4d3612044d8688ac17e11de81c07e5` — Record v13.0 Scrub Key model in changelog.
49
+
50
+ Connector findings:
51
+
52
+ - GitHub combined status returned `statuses: []` for checked WP3 commits.
53
+ - Commit workflow-run lookup returned `workflow_runs: []` for checked WP3 commits.
54
+ - GitHub combined status returned `statuses: []` for `d65364373e4d3612044d8688ac17e11de81c07e5`.
55
+ - Commit workflow-run lookup returned `workflow_runs: []` for `d65364373e4d3612044d8688ac17e11de81c07e5`.
56
+ - Because of this, this worker did not mark Actions/sync as green.
57
+
58
+ Recorded repo evidence:
59
+
60
+ - WP3 handover records local targeted validation:
61
+ - `PYTHONPATH=. pytest -q tests/test_export_sanity.py tests/test_review_summary.py` → 12 passed.
62
+ - WP4 changelog records local targeted validation:
63
+ - `PYTHONPATH=. pytest -q tests/test_scrub_key.py` → 6 passed.
64
+
65
+ Files changed:
66
+
67
+ - `WORKPACKAGES.md`
68
+ - `CHANGELOG.md`
69
+ - `handover/workpackages/20260607_1425_wp3_wp4_status_reconciliation.md`
70
+
71
+ Intentionally not changed:
72
+
73
+ - No code files.
74
+ - No UI files.
75
+ - No tests.
76
+ - No export semantics.
77
+ - No Hugging Face app behavior.
78
+
79
+ Next step:
80
+
81
+ - Coordinator should verify the latest GitHub Actions `Tests` and GitHub to Hugging Face sync in the GitHub UI, because the connector did not expose workflow-run evidence for these commits.
82
+
83
+ ---
84
+
85
  ## v13.0 — Scrub Key specification and pure model
86
 
87
+ Status: implemented; local targeted tests passed; GitHub Actions and Hugging Face sync not independently confirmed by this worker.
88
 
89
  Purpose:
90
 
 
132
  - Added `tests/test_scrub_key.py`.
133
  - Local targeted validation passed: `PYTHONPATH=. pytest -q tests/test_scrub_key.py` → 6 passed.
134
  - Tests cover valid key creation, excluded-row omission, required fields, JSON roundtrip, validation errors, and synthetic Dutch legal examples only.
135
+ - Connector check attempted for commit `d65364373e4d3612044d8688ac17e11de81c07e5`, but no check/status evidence was exposed.
136
 
137
  Intentionally not changed:
138
 
 
147
 
148
  ---
149
 
150
+ ## v12.6 — Export sanity checks helper and tests
151
+
152
+ Status: helper implemented; local targeted tests passed; GitHub Actions and Hugging Face sync not independently confirmed by this worker.
153
+
154
+ Purpose:
155
+
156
+ - Prepare advisory export sanity-check logic before UI integration.
157
+ - Warn users when review risk remains.
158
+ - Preserve existing export semantics and download behavior.
159
+
160
+ Files added or changed:
161
+
162
+ - `export_sanity.py`
163
+ - `tests/test_export_sanity.py`
164
+ - `WORKPACKAGES.md`
165
+ - `handover/workpackages/20260607_1405_v12_6_export_sanity_helper.md`
166
+
167
+ Main changes:
168
+
169
+ - Added pure helper logic for advisory export readiness checks.
170
+ - Added Dutch user-facing warning text for:
171
+ - unchecked `Controle nodig` rows;
172
+ - candidate rows not included;
173
+ - no replacements selected;
174
+ - user review still required;
175
+ - export not guaranteeing full anonymization.
176
+ - Added readiness labels:
177
+ - `Geen vervangregels gevonden — controleer handmatig`;
178
+ - `Geen vervangingen geselecteerd`;
179
+ - `Controle nodig vóór export`;
180
+ - `Klaar voor export na gebruikerscontrole`.
181
+ - Explicitly preserved helper flags:
182
+ - `blocks_export = False`;
183
+ - `changes_export_semantics = False`.
184
+ - Reused review-summary normalization logic where helpful.
185
+
186
+ Testing:
187
+
188
+ - Added `tests/test_export_sanity.py`.
189
+ - Local targeted validation passed in the WP3 handover:
190
+ - `PYTHONPATH=. pytest -q tests/test_export_sanity.py tests/test_review_summary.py` → 12 passed.
191
+ - Connector check attempted for WP3 commits `5342e0eef663817036e91f823b4389b338b9223c`, `704ae03788702ce33263343743a69f8139f16319`, `869e3804edf04e0cbdf7ab69b034e7bc707de8c3`, and `4d721e3aed3bf28cfdaeb096c0e9cd227885f1a6`, but no check/status evidence was exposed.
192
+
193
+ Intentionally not changed:
194
+
195
+ - No direct edit to `presidio_streamlit.py`.
196
+ - No direct edit to `fix_streamlit_nested_expanders.py`.
197
+ - No change to `review_summary.py`.
198
+ - No export/download blocking.
199
+ - No change to which rows are included in export.
200
+ - No Scrub Key or reinsert implementation.
201
+ - No LLM/cloud feature.
202
+
203
+ ---
204
+
205
  ## v12.5 — Final review summary
206
 
207
  Status: completed and app verified.