Spaces:
Running
Running
solidprivacy-nl commited on
Commit ·
b8ac0f9
1
Parent(s): d115ca5
Document v12.1 review status model
Browse files- CHANGELOG.md +69 -22
CHANGELOG.md
CHANGED
|
@@ -26,6 +26,64 @@ This prevents one-off fixes and protects existing behaviour.
|
|
| 26 |
|
| 27 |
---
|
| 28 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 29 |
## v11.2 — Dutch recognizer integration tests
|
| 30 |
|
| 31 |
Status: completed and green in GitHub Actions.
|
|
@@ -340,39 +398,28 @@ Important design conclusions:
|
|
| 340 |
|
| 341 |
---
|
| 342 |
|
| 343 |
-
## Planned next phase — v12 Review
|
| 344 |
|
| 345 |
Status: planned, not yet implemented.
|
| 346 |
|
| 347 |
Goal:
|
| 348 |
|
| 349 |
-
-
|
| 350 |
|
| 351 |
Planned scope:
|
| 352 |
|
| 353 |
-
-
|
| 354 |
-
|
| 355 |
-
|
| 356 |
-
|
| 357 |
-
|
| 358 |
-
-
|
| 359 |
-
|
| 360 |
-
|
| 361 |
-
- clearer Dutch labels.
|
| 362 |
-
- Filters:
|
| 363 |
-
- show only “controle nodig”;
|
| 364 |
-
- show only legal references;
|
| 365 |
-
- show only names/addresses;
|
| 366 |
-
- show only low-confidence items.
|
| 367 |
-
- Better candidate warnings:
|
| 368 |
-
- clearly explain that candidates are not automatically replaced unless selected.
|
| 369 |
-
- Hide technical entity types and raw scores by default; keep them available in an advanced/technical view.
|
| 370 |
-
|
| 371 |
-
Non-goals for v12:
|
| 372 |
|
|
|
|
| 373 |
- No MSI/local desktop packaging yet.
|
| 374 |
- No LLM integration.
|
| 375 |
-
- No broad new recognizer families unless required to support the review UX.
|
| 376 |
|
| 377 |
---
|
| 378 |
|
|
|
|
| 26 |
|
| 27 |
---
|
| 28 |
|
| 29 |
+
## v12.1 — Review table status model
|
| 30 |
+
|
| 31 |
+
Status: implemented; awaiting GitHub Actions and Hugging Face verification.
|
| 32 |
+
|
| 33 |
+
Purpose:
|
| 34 |
+
|
| 35 |
+
- Start the v12 Review UX phase with a simple, explicit review-status model.
|
| 36 |
+
- Make it clearer to a legal user which rows are already applied, which need review, which are manual, and which come from remembered replacements.
|
| 37 |
+
- Keep recognizer logic unchanged.
|
| 38 |
+
|
| 39 |
+
Files added or changed:
|
| 40 |
+
|
| 41 |
+
- `review_status.py`
|
| 42 |
+
- `tests/test_review_status.py`
|
| 43 |
+
- `fix_streamlit_nested_expanders.py`
|
| 44 |
+
- `CHANGELOG.md`
|
| 45 |
+
|
| 46 |
+
Main changes:
|
| 47 |
+
|
| 48 |
+
- Added a pure review-status model with stable internal values:
|
| 49 |
+
- `auto_detected`
|
| 50 |
+
- `needs_review`
|
| 51 |
+
- `manual`
|
| 52 |
+
- `remembered`
|
| 53 |
+
- Added Dutch user-facing labels:
|
| 54 |
+
- `Automatisch vervangen`
|
| 55 |
+
- `Controle nodig`
|
| 56 |
+
- `Handmatig toegevoegd`
|
| 57 |
+
- `Onthouden vervanging`
|
| 58 |
+
- Added sorting order so rows needing review appear before automatically applied rows.
|
| 59 |
+
- Added tests for source-to-status mapping and ordering.
|
| 60 |
+
- Extended the existing Streamlit startup patch so the replacement table gets:
|
| 61 |
+
- a visible `Status` column;
|
| 62 |
+
- hidden/internal `review_status` and `review_order` fields;
|
| 63 |
+
- a compact status summary above the editor;
|
| 64 |
+
- status values included in report rows where supported by downstream exports.
|
| 65 |
+
|
| 66 |
+
Important design decision:
|
| 67 |
+
|
| 68 |
+
- This phase deliberately does not add filters yet.
|
| 69 |
+
- v12.1 only introduces the status model and visible status column.
|
| 70 |
+
- Filters and further table simplification are planned for v12.2 and v12.3.
|
| 71 |
+
|
| 72 |
+
Testing:
|
| 73 |
+
|
| 74 |
+
- Added unit tests for `review_status.py`.
|
| 75 |
+
- GitHub Actions status still needs to be checked after this changelog update.
|
| 76 |
+
- Hugging Face app should be checked after sync.
|
| 77 |
+
|
| 78 |
+
Intentionally not changed:
|
| 79 |
+
|
| 80 |
+
- No recognizer changes.
|
| 81 |
+
- No new entity types.
|
| 82 |
+
- No MSI/local installer work.
|
| 83 |
+
- No LLM/cloud feature.
|
| 84 |
+
|
| 85 |
+
---
|
| 86 |
+
|
| 87 |
## v11.2 — Dutch recognizer integration tests
|
| 88 |
|
| 89 |
Status: completed and green in GitHub Actions.
|
|
|
|
| 398 |
|
| 399 |
---
|
| 400 |
|
| 401 |
+
## Planned next phase — v12.2 Review filters
|
| 402 |
|
| 403 |
Status: planned, not yet implemented.
|
| 404 |
|
| 405 |
Goal:
|
| 406 |
|
| 407 |
+
- Add filters on top of the v12.1 status model.
|
| 408 |
|
| 409 |
Planned scope:
|
| 410 |
|
| 411 |
+
- Show all.
|
| 412 |
+
- Show only `Controle nodig`.
|
| 413 |
+
- Show only legal references.
|
| 414 |
+
- Show only names/addresses.
|
| 415 |
+
- Show only low-confidence items.
|
| 416 |
+
- Keep technical columns hidden by default where possible.
|
| 417 |
+
|
| 418 |
+
Non-goals for v12.2:
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 419 |
|
| 420 |
+
- No recognizer changes.
|
| 421 |
- No MSI/local desktop packaging yet.
|
| 422 |
- No LLM integration.
|
|
|
|
| 423 |
|
| 424 |
---
|
| 425 |
|