Record v13.6 two-mode content separation cleanup

WORKPACKAGES.md

@@ -273,43 +273,70 @@ Outcome:
 
 ---
 
-## Current implementation workpackage
+## Current implementation workpackages
 
 ### WP12 — v13.6 Two-mode UI skeleton and tab separation
 
-Status: implemented; awaiting GitHub Actions, Hugging Face sync and app verification.
+Status: implemented; coordinator evidence showed Actions/sync green, but app verification found insufficient content separation.
 
-Added files:
+Coordinator evidence:
 
-- `tests/test_two_mode_ui_patch.py`
-- `handover/workpackages/20260608_0000_v13_6_two_mode_ui_skeleton.md`
+```text
+Tests #145 green — commit 5d879cc
+Sync #159 green — commit 5d879cc
+Tests #146 green — commit 79d771e
+Sync #160 green — commit 79d771e
+Tests #147 green — commit e106f7c
+Sync #161 green — commit e106f7c
+```
+
+Outcome:
+
+- The visual mode navigation existed.
+- App verification showed the full anonymization workflow still appeared above the reinsert flow when using `Originele waarden terugzetten`.
+- This required WP12-FIX.
+
+### WP12-FIX — v13.6 Two-mode UI content separation cleanup
+
+Status: implemented; awaiting GitHub Actions, Hugging Face sync and app verification.
 
 Changed files:
 
 - `fix_streamlit_nested_expanders.py`
+- `tests/test_two_mode_ui_patch.py`
 - `WORKPACKAGES.md`
 - `CHANGELOG.md`
 
+Added files:
+
+- `handover/workpackages/20260608_0000_v13_6_two_mode_content_separation_cleanup.md`
+
 Implemented behavior:
 
-- Added a minimal two-mode UI skeleton through the existing startup patch flow.
-- Adds visible Streamlit tabs near the top of the app:
-  - `Anonimiseren`;
-  - `Originele waarden terugzetten`.
-- Adds short captions that explain the privacy intent of each mode.
-- Keeps the existing anonymization/scrub workflow available.
-- Keeps existing Scrub Key export/import labels available.
-- Keeps existing pasted-text reinsert workflow available.
-- Keeps existing scrubbed TXT/CSV/DOCX/PDF downloads unchanged.
+- Replaced skeleton-only tab captions with an actual work-mode selector using `solidprivacy_work_mode = st.radio(...)`.
+- If mode is `Originele waarden terugzetten`, the patched app renders only:
+  - `Scrub Key laden`;
+  - Scrub Key upload/paste validation;
+  - local pasted-text reinsert;
+  - restored-output warning;
+  - local-only/no-AI/no-cloud text;
+  - `Zet originele waarden lokaal terug`;
+  - `Herstelde tekst`;
+  - `Download herstelde tekst (.txt)`;
+  - `Controleverslag terugzetten`.
+- The existing anonymization workflow is placed under the `else` branch for `Anonimiseren`.
+- The anonymization/export review summary keeps Scrub Key export, but no longer embeds Scrub Key import/reinsert inside the export block.
 
 Validation status:
 
-- Added `tests/test_two_mode_ui_patch.py` with patch-level checks for:
-  - mode labels;
-  - Streamlit tabs;
-  - existing Scrub Key export/import labels;
-  - existing pasted-text reinsert labels;
-  - existing scrubbed download markers;
+- Updated `tests/test_two_mode_ui_patch.py` to verify:
+  - both modes exist;
+  - conditional work-mode rendering exists;
+  - reinsert markers are associated with the reinsert branch;
+  - anonymization markers are associated with the `else` branch;
+  - reinsert flow is not embedded in the anonymization review/export summary block;
+  - existing Scrub Key export/import labels remain;
+  - existing scrubbed download markers remain;
   - no TXT upload reinsert UI;
   - no DOCX upload reinsert UI;
   - no PDF reinsert;
@@ -330,15 +357,15 @@ Boundaries preserved:
 - No AI calls added.
 - No cloud processing added.
 - No automatic document rehydration added.
-- No existing scrubbed export/download semantics intentionally changed.
-- No Scrub Key export/import behavior intentionally changed.
+- No existing scrubbed export/download semantics intentionally changed inside `Anonimiseren`.
+- No Scrub Key JSON export behavior intentionally changed inside `Anonimiseren`.
 - No secrets, tokens or real personal data stored.
 
 ---
 
 ## Active / next recommended workpackage
 
-### WP12B — v13.6 Two-mode UI skeleton app verification closeout
+### WP12-FIX-CLOSEOUT — v13.6 Two-mode content separation app verification closeout
 
 Status: recommended next closeout workpackage after coordinator evidence.
 
@@ -346,23 +373,41 @@ Goal:
 
 - Verify GitHub Actions tests.
 - Verify GitHub to Hugging Face sync.
-- Verify the Hugging Face app UI.
-- Close WP12 only after evidence shows the UI still works.
+- Verify app behavior for both modes.
+- Close WP12-FIX only after evidence shows the UI content is truly separated.
 
 Required app verification:
 
-- `Anonimiseren` mode is visible.
-- `Originele waarden terugzetten` mode is visible.
-- Anonymization workflow still works.
-- Review table still appears.
-- Scrub Key JSON export still appears.
-- Scrub Key import/reload still appears.
-- Pasted-text reinsert still works.
-- `Download herstelde tekst (.txt)` still works.
-- Existing scrubbed TXT/CSV/DOCX/PDF downloads remain available.
-- No TXT/DOCX upload reinsert UI appears yet.
-- No PDF reinsert appears.
-- No AI/cloud behavior appears.
+In `Anonimiseren`:
+
+- anonymization workflow is visible;
+- source text/file input is visible;
+- review table still appears;
+- Scrub Key JSON export still appears;
+- scrubbed TXT/CSV/DOCX/PDF downloads remain available;
+- pasted-text reinsert is not presented as part of the anonymization workflow.
+
+In `Originele waarden terugzetten`:
+
+- anonymization source input is not shown as the main workflow;
+- review table is not shown;
+- scrubbed export section is not shown;
+- `Scrub Key laden` is visible;
+- Scrub Key upload/paste validation is visible;
+- pasted-text reinsert is visible;
+- `Zet originele waarden lokaal terug` works;
+- `Herstelde tekst` appears after reinsert;
+- `Download herstelde tekst (.txt)` works;
+- audit summary / `Controleverslag terugzetten` appears;
+- warning about restored sensitive/confidential data is visible;
+- local-only/no-AI/no-cloud text is visible.
+
+Also confirm:
+
+- no TXT upload reinsert UI appears yet;
+- no DOCX upload reinsert UI appears yet;
+- no PDF reinsert appears;
+- no AI/cloud behavior appears.
 
 Recommended later workpackages:
 
@@ -376,10 +421,10 @@ WP15 — PDF text extraction reliability review only
 
 ## Recommended execution order
 
-1. Verify WP12 GitHub Actions and Hugging Face sync.
-2. Verify the Hugging Face app for the two-mode skeleton.
-3. Close WP12 through WP12B if verification is green.
-4. After WP12 is app-verified, implement TXT reinsert upload/download UI.
+1. Verify WP12-FIX GitHub Actions and Hugging Face sync.
+2. Verify the Hugging Face app for actual two-mode content separation.
+3. Close WP12-FIX through closeout if verification is green.
+4. After WP12-FIX is app-verified, implement TXT reinsert upload/download UI.
 5. After TXT UI is verified, implement DOCX reinsert upload/download UI.
 6. Keep PDF full reinsert out of scope until a separate reliability review.
 7. Keep AI/cloud behavior out unless explicitly approved.