Add v12.5 review summary handover

handover/workpackages/20260607_1309_v12_5_review_summary_helper.md

@@ -0,0 +1,170 @@
+# Handover — WP2 v12.5 Final review summary helper
+
+Repository: solidprivacy-nl/scrub  
+Status: helper and tests implemented; UI integration pending WP1 verification and latest Actions/sync confirmation
+
+## Summary
+
+This work continued from the fresh-chat handover and followed the required start sequence by reading:
+
+1. `PROJECT_PROMPT.md`
+2. `ROADMAP.md`
+3. `WORKPACKAGES.md`
+4. `CHANGELOG.md`
+
+The active repository was confirmed as `solidprivacy-nl/scrub` with write access.
+
+The current workpackage plan allowed WP2 helper and tests to be prepared while WP1 / v12.4 verification remains pending. Therefore this worker implemented only the pure helper module and tests for the final review summary. No Streamlit UI integration was performed.
+
+## Repository worked in
+
+- `solidprivacy-nl/scrub`
+
+## Workpackage title
+
+- `WP2 — v12.5 Final review summary helper`
+
+## Status
+
+- Helper module implemented.
+- Unit tests implemented.
+- Local targeted test passed.
+- UI integration not started.
+- Latest GitHub Actions and Hugging Face sync still need external verification.
+
+## Files added
+
+- `review_summary.py`
+- `tests/test_review_summary.py`
+- `handover/workpackages/20260607_1309_v12_5_review_summary_helper.md`
+
+## Files changed
+
+- `WORKPACKAGES.md`
+- `CHANGELOG.md`
+
+## Main changes
+
+### `review_summary.py`
+
+Added a pure helper layer for the final review/export readiness summary.
+
+It can count:
+
+- total replacement rows;
+- automatically detected rows;
+- rows needing review;
+- manually added rows;
+- remembered replacement rows;
+- checked rows included in export;
+- unchecked rows excluded from export;
+- open unchecked candidate rows.
+
+It also adds:
+
+- conservative include parsing for booleans, numbers and Dutch/string values;
+- status inference from stable status values, Dutch labels, source fields and manual/remembered entity markers;
+- Dutch readiness labels;
+- Dutch markdown-ready summary lines for later UI integration.
+
+### `tests/test_review_summary.py`
+
+Added tests for:
+
+- expected status group counts;
+- export include/exclude counts;
+- open candidate warning;
+- Dutch label and source fallback inference;
+- empty and unselected states;
+- Dutch user-facing summary lines and markdown output.
+
+### `WORKPACKAGES.md`
+
+Updated WP2 status from planned to:
+
+```text
+helper and tests implemented; UI integration pending WP1 verification
+```
+
+The recommended execution order now keeps UI integration gated behind WP1/v12.4 verification.
+
+### `CHANGELOG.md`
+
+Added/updated entries for:
+
+- v12.5 final review summary helper;
+- v12.4 review guidance text;
+- project governance setup;
+- v12.3 status after user-confirmed bugfix.
+
+Note: the changelog was also condensed into a clearer human-readable history. Older detailed examples were summarized rather than preserved verbatim.
+
+## Tests
+
+Local targeted validation performed before committing:
+
+```bash
+PYTHONPATH=. pytest -q tests/test_review_summary.py
+```
+
+Result:
+
+```text
+5 passed
+```
+
+## Validation status
+
+- Local targeted helper tests: passed.
+- Full local test suite: not run; the container could not clone GitHub because external network/DNS was unavailable.
+- GitHub Actions: unknown. The GitHub connector returned empty combined statuses and no workflow runs for the latest push commits.
+- Hugging Face sync: unknown. Needs external confirmation in GitHub Actions.
+- App verification: not applicable for this helper-only step because no UI behavior was changed.
+
+## GitHub commits created
+
+- `ae6752df070d6b031b99b67f29921c64d080466f` — Add review summary helper
+- `e336642fa6e75d8d712902284d1c992f01ca7913` — Add review summary tests
+- `d8a93c146e28592894f38625a416511efa971e28` — Update workpackage status for review summary helper
+- `221b249fdd0c4253ea9ac7a0379c96cb02f25cec` — Log review summary helper work
+
+## GitHub Actions status
+
+Unknown.
+
+The connector returned:
+
+```text
+statuses: []
+workflow_runs: []
+```
+
+for the latest changelog commit, so the coordinator should check GitHub Actions directly.
+
+## Hugging Face sync status
+
+Unknown.
+
+Because GitHub Actions status could not be confirmed through the connector, the Hugging Face sync should also be checked directly.
+
+## App verification status
+
+- No new app verification required for this helper-only change.
+- Previous v12.4 review guidance was visually confirmed by the user before this work.
+- Future WP2 UI integration will require app verification after sync.
+
+## Remaining risks
+
+- WP1/v12.4 latest Actions and Hugging Face sync are still not confirmed through the connector.
+- WP2 UI integration must not start until WP1 verification is confirmed.
+- `fix_streamlit_nested_expanders.py` still carries multiple staged UI patches, so future UI changes should remain sequential and careful.
+- `CHANGELOG.md` was condensed; older detailed historical examples are summarized rather than fully repeated.
+- No full-suite local validation was possible in this environment.
+
+## Next recommended step
+
+1. Confirm GitHub Actions and Hugging Face sync for the latest commits, including this handover commit.
+2. Confirm WP1/v12.4 remains stable in the Hugging Face app.
+3. Only then integrate WP2 summary into the UI above the download/export section.
+4. After WP2 UI integration, ask for Hugging Face app verification.
+5. Then continue with WP3 — v12.6 Export sanity checks.